Get texidoc translations out of snippets source files

Get texidoc translations out of snippets source files

Texidoc translations are inserted in .ly snippets at build stage
instead of makelsr.py run.

This simplifies overall maintenance of snippets, in particular
this avoids Git committish update headache for translators.

See final discussion at
http://lists.gnu.org/archive/html/lilypond-devel/2012-06/msg00438.html

[Graham Percival, 2012-06-29 11:05:06]

LGTM.

[PhilEHolmes, 2012-06-29 15:56:03]

LGTM with one proposed change.

http://codereview.appspot.com/6352053/diff/1/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):

http://codereview.appspot.com/6352053/diff/1/scripts/auxiliar/makelsr.py#newc...
scripts/auxiliar/makelsr.py:79: default="out/bin",
This all looks excellent and very fine work, with one minor nit-pick.  My
default directory for convert-ly is build/out/bin, not out/bin.  Ditto the
lilypond binary.  It's likely to be the usual default.  The option code here
uses the non-out-of-tree build directory (over-writing a change I'd made earlier
to search for the correct directory) and as a result lilypond and convert-ly
don't get run on my system, and my first run gave a failed doc build owing to
non-updated scheme code.  I think it would be better if the default was the
build/out directory, and if convert-ly and lilypond aren't found, the script
fails, with a message about how to use the -p option.

[mail_philholmes.net, 2012-06-29 17:11:17]

----- Original Message ----- 
From: "Graham Percival" <graham@percival-music.ca>
To: <john.mandereau@gmail.com>; <phileholmes@googlemail.com>; 
<lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Friday, June 29, 2012 5:27 PM
Subject: Re: Get texidoc translations out of snippets source files 
(issue6352053)


> On Fri, Jun 29, 2012 at 03:56:03PM +0000, PhilEHolmes@googlemail.com 
> wrote:
>>
http://codereview.appspot.com/6352053/diff/1/scripts/auxiliar/makelsr.py#newc...
>> scripts/auxiliar/makelsr.py:79: default="out/bin",
> ...
>> it would be better if the default was the build/out directory, and if
>> convert-ly and lilypond aren't found, the script fails, with a message
>> about how to use the -p option.
>
> Excellent catch!  But let's take that one step further, and use
> $LILYPOND_BUILD_DIR/out/bin/ as the default.  Now that John has
> gone through the fuss of creating it, let's use it.  :)
>
> - Graham


I think we may need to be careful how we get this patch into master, since 
it has a specific sequence of events associated: makelsr-from-tarball using 
this patch; push resulting Doc/snippets to git - if step one is done and 
step 2 delayed, we may get unpredictable results.

--
Phil Holmes 

[mail_philholmes.net, 2012-06-30 14:31:56]

----- Original Message ----- 
From: "Phil Holmes" <mail@philholmes.net>
To: "Graham Percival" <graham@percival-music.ca>; 
<john.mandereau@gmail.com>; <phileholmes@googlemail.com>; 
<lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Friday, June 29, 2012 6:11 PM
Subject: Re: Get texidoc translations out of snippets source 
files(issue6352053)


> ----- Original Message ----- 
> From: "Graham Percival" <graham@percival-music.ca>
> To: <john.mandereau@gmail.com>; <phileholmes@googlemail.com>; 
> <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
> Sent: Friday, June 29, 2012 5:27 PM
> Subject: Re: Get texidoc translations out of snippets source files 
> (issue6352053)
>
>
>> On Fri, Jun 29, 2012 at 03:56:03PM +0000, PhilEHolmes@googlemail.com 
>> wrote:
>>>
http://codereview.appspot.com/6352053/diff/1/scripts/auxiliar/makelsr.py#newc...
>>> scripts/auxiliar/makelsr.py:79: default="out/bin",
>> ...
>>> it would be better if the default was the build/out directory, and if
>>> convert-ly and lilypond aren't found, the script fails, with a message
>>> about how to use the -p option.
>>
>> Excellent catch!  But let's take that one step further, and use
>> $LILYPOND_BUILD_DIR/out/bin/ as the default.  Now that John has
>> gone through the fuss of creating it, let's use it.  :)
>>
>> - Graham
>
>
> I think we may need to be careful how we get this patch into master, since 
> it has a specific sequence of events associated: makelsr-from-tarball 
> using this patch; push resulting Doc/snippets to git - if step one is done 
> and step 2 delayed, we may get unpredictable results.
>
> --
> Phil Holmes


I see the patch is now in master.  I think this means I need to use an 
archived copy of the LSR (the one I used for the last update of git from the 
tarball) to update Documentation/snippets using John's new script and push 
the resultant snippets to staging.  That way, git will have newly "correct" 
versions of the snippets - without extraneous translations in them.

Once that's OK, I'll grab a new tarball and repeat.

Agreed?

--
Phil Holmes 

[PhilEHolmes, 2012-07-13 14:25:37]

One difficulty I've discovered - locating convert-ly.  I'm continuing other
testing.

http://codereview.appspot.com/6352053/diff/6008/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (left):

http://codereview.appspot.com/6352053/diff/6008/scripts/auxiliar/makelsr.py#o...
scripts/auxiliar/makelsr.py:7: 
The code here, which is trying to find the lilypond bin and convert-ly now has
no effect - it's overwritten below.  See below.

http://codereview.appspot.com/6352053/diff/6008/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):

http://codereview.appspot.com/6352053/diff/6008/scripts/auxiliar/makelsr.py#n...
scripts/auxiliar/makelsr.py:83: 
This changes where we expect to look for lilypond by default, unless there's a
command-line option.

http://codereview.appspot.com/6352053/diff/6008/scripts/auxiliar/makelsr.py#n...
scripts/auxiliar/makelsr.py:167: sys.stderr.write ("Warning: %s: no such file")
This needs an argument, and a CR/LF and should exit if it can't find convert-ly.

http://codereview.appspot.com/6352053/diff/6008/scripts/auxiliar/makelsr.py#n...
scripts/auxiliar/makelsr.py:175: lilypond_bin = "lilypond"
Ditto.