Issue 6351083: Get texidoc translations out of snippets source files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351083: Get texidoc translations out of snippets source files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by John Mandereau

Modified:
11 years, 9 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Get texidoc translations out of snippets source files Texidoc translations are inserted in .ly snippets at build stage instead of makelsr.py run. This simplifies overall maintenance of snippets, in particular this avoids Git committish update headache for translators. By the way, fix dependencies on snippets in Documentation/GNUmakefile. See final discussion at http://lists.gnu.org/archive/html/lilypond-devel/2012-06/msg00438.html

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+247 lines, -176 lines)			Patch
M	Documentation/GNUmakefile	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	Documentation/contributor/doc-work.itexi	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	Documentation/contributor/lsr-work.itexi	View	3 chunks	+17 lines, -19 lines	1 comment	Download
M	Documentation/snippets/GNUmakefile	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	make/lilypond-vars.make	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/auxiliar/makelsr.py	View	7 chunks	+176 lines, -133 lines	0 comments	Download
A	scripts/build/makesnippets.py	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

http://codereview.appspot.com/6351083/diff/1/Documentation/contributor/lsr-work.itexi File Documentation/contributor/lsr-work.itexi (right): http://codereview.appspot.com/6351083/diff/1/Documentation/contributor/lsr-work.itexi#newcode209 Documentation/contributor/lsr-work.itexi:209: e.g. 2011-12-25. @command{make} is included in this sequence so ...

11 years, 9 months ago (2012-07-11 04:15:47 UTC) #1

John Mandereau

11 years, 9 months ago (2012-07-11 11:37:32 UTC) #2

On 2012/07/11 04:15:47, lemzwerg wrote:
>
http://codereview.appspot.com/6351083/diff/1/Documentation/contributor/lsr-wo...
> File Documentation/contributor/lsr-work.itexi (right):
> 
>
http://codereview.appspot.com/6351083/diff/1/Documentation/contributor/lsr-wo...
> Documentation/contributor/lsr-work.itexi:209: e.g. 2011-12-25. @command{make}
is
> included in this sequence so that
> Please use two spaces after a full dot everywhere (and please check your whole
> patch for other occurrences).

Thanks for this catch, I'm updating the other Rietveld issue, though (6352053).

Cheers,
John

Expand All Messages | Collapse All Messages