code review 6351053: cmd/go: capture SIGQUIT during go run

cmd/go: capture SIGQUIT during go run

Fixes issue 3581.

[dave_cheney.net, 2012-06-29 11:34:53]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2012-07-02 02:10:38]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2012-07-06 10:24:16]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2012-07-12 00:08:34]

On 2012/07/06 10:24:16, dfc wrote:
> Hello mailto:bradfitz@golang.org (cc: mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

<ping />

[rsc, 2012-07-30 00:42:42]

http://codereview.appspot.com/6351053/diff/8003/src/cmd/go/run.go
File src/cmd/go/run.go (right):

http://codereview.appspot.com/6351053/diff/8003/src/cmd/go/run.go#newcode89
src/cmd/go/run.go:89: // capture SIGQUIT so the subprocess can print
I'm confused. Calling signal.Notify here applies to the parent process, not the
subprocess. And then nothing happens with the signal channel. If the goal is
some kind of side effect like the child inheriting a non-default signal handler
for SIGQUIT, that should be made more explicit in the comment, and it should
probably also be done in a func init once for the whole lifetime of the process
instead of each time runStdin is called.

Or if this is only for 'go run', then the 'go run' code can do this instead of
doing it here in a helper function.