Define sys_stat64 for Android

I patched this when I originally added Android support for Breakpad, but it looks like in newer NDKs this doesn't break things. Also, sys_stat doesn't work reliably now, I get EOVERFLOW trying to use it.

[ted, 2012-07-12 18:23:09]

Ugh, my test program didn't #include <sys/stat.h>. This is still broken on
Android. I'll see if I can find a better workaround.

[digit, 2012-07-12 18:24:24]

http://codereview.appspot.com/6349099/diff/1/lss/linux_syscall_support.h
File lss/linux_syscall_support.h (left):

http://codereview.appspot.com/6349099/diff/1/lss/linux_syscall_support.h#oldc...
lss/linux_syscall_support.h:3037: /* The Android NDK #defines stat64 stat, so
avoid multiple-definition */
As far as I know, the NDK's <sys/stat.h> still does that to support client code
that uses stat64(). That's because 'struct stat' is really the same than
'kernel_stat64' on this platform'.

Maybe a better solution would be to undefine the macros instead, at the top of
this file, as in:

  #ifdef __ANDROID__
  // Android's <sys/stat.h> defines these macros as aliases
  // to their non-64 counterpart. To avoid naming conflict
  // remove them.
  #  undef stat64
  #  undef fstat64
  #  undef lstat64
  #endif

[ted, 2012-07-12 19:17:21]

On Thu, Jul 12, 2012 at 2:24 PM,  <digit@google.com> wrote:
> Maybe a better solution would be to undefine the macros instead, at the
> top of this file, as in:

Apparently my original patch had that, but it got removed before being
committed:
http://codereview.chromium.org/3656004#msg1

I think I'll have to revert to that to make things work properly.

[digit1, 2012-07-13 10:52:54]

lgtm (but I'm not an owner :-)

[mseaborn1, 2012-07-13 12:13:35]

LGTM, but please put "Define sys_stat64 for Android" as the first line of the
description, because gcl/git-cl don't use Rietveld's Subject line when
committing -- they just use the description field for the commit message.

http://codereview.appspot.com/6349099/diff/5002/lss/linux_syscall_support.h
File lss/linux_syscall_support.h (right):

http://codereview.appspot.com/6349099/diff/5002/lss/linux_syscall_support.h#n...
lss/linux_syscall_support.h:125: # pragma push_macro("stat64")
I hadn't seen "#pragma push_macro" before.  Maybe add a comment that this
matches up with pop_macro below?

http://codereview.appspot.com/6349099/diff/5002/lss/linux_syscall_support.h#n...
lss/linux_syscall_support.h:3523: # pragma pop_macro("stat64")
Similarly, comment that this undoes push_macro, perhaps?

[ted, 2012-07-13 15:19:18]

Can you commit this for me?

[digit1, 2012-09-05 12:01:27]

Mark, can you commit this for Ted? This is blocking a related Breakpad patch.
Thanks.

[thestig, 2012-09-05 17:59:26]

spamming the other lss committers

[mseaborn1, 2012-09-05 18:28:37]

On 2012/09/05 12:01:27, digit1 wrote:
> Mark, can you commit this for Ted? This is blocking a related Breakpad
> patch. Thanks.

I've committed it for you:
http://code.google.com/p/linux-syscall-support/source/detail?r=12

Mark