code review 6348067: encoding/gob: fix bug in Register

encoding/gob: fix bug in Register
The old code added a star but did not indirect the reflect.Type.

[r, 2012-07-02 23:48:54]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-07-03 00:05:51]

LGTM

On Mon, Jul 2, 2012 at 4:48 PM, <r@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> encoding/gob: fix bug in Register
> The old code added a star but did not indirect the reflect.Type.
>
> Please review this at
http://codereview.appspot.com/**6348067/<http://codereview.appspot.com/6348067/>
>
> Affected files:
>   M src/pkg/encoding/gob/type.go
>
>
> Index: src/pkg/encoding/gob/type.go
> ==============================**==============================**=======
> --- a/src/pkg/encoding/gob/type.go
> +++ b/src/pkg/encoding/gob/type.go
> @@ -755,7 +755,7 @@
>         if rt.Name() == "" {
>                 if pt := rt; pt.Kind() == reflect.Ptr {
>                         star = "*"
> -                       rt = pt
> +                       rt = pt.Elem()
>                 }
>         }
>         if rt.Name() != "" {
>
>
>

[r, 2012-07-03 17:05:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=c89f17a9ff4f ***

encoding/gob: fix bug in Register
The old code added a star but did not indirect the reflect.Type.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/6348067

[albert.strasheim, 2012-07-05 13:19:56]

Does it make sense that this change could break compatibility between Go
programs compiled before the change and ones compiled after the change?

We seem to be seeing that in our system, but maybe something else is wrong.

Cheers

Albert

On 2012/07/03 17:05:29, r wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=c89f17a9ff4f ***
> 
> encoding/gob: fix bug in Register
> The old code added a star but did not indirect the reflect.Type.
> 
> R=bradfitz
> CC=golang-dev
> http://codereview.appspot.com/6348067

[r, 2012-07-09 15:40:53]

Conceivable, yes, but only because the gob package was wrong and client
code was working around the bug. Send me details if you want me to
investigate.

-rob



On Thu, Jul 5, 2012 at 6:19 AM, <fullung@gmail.com> wrote:

> Does it make sense that this change could break compatibility between Go
> programs compiled before the change and ones compiled after the change?
>
> We seem to be seeing that in our system, but maybe something else is
> wrong.
>
> Cheers
>
> Albert
>
>
> On 2012/07/03 17:05:29, r wrote:
>
>> *** Submitted as
>>
>
http://code.google.com/p/go/**source/detail?r=c89f17a9ff4f<http://code.google...
>
>  encoding/gob: fix bug in Register
>> The old code added a star but did not indirect the reflect.Type.
>>
>
>  R=bradfitz
>> CC=golang-dev
>>
http://codereview.appspot.com/**6348067<http://codereview.appspot.com/6348067>
>>
>
>
http://codereview.appspot.com/**6348067/<http://codereview.appspot.com/6348067/>
>