Issue 6347064: Weight transfer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6347064: Weight transfer

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Cyborgmuppet

Modified:
11 years, 10 months ago

Reviewers:
ideasman42, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

More Reviews

Description

Weight transfer

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+382 lines, -3 lines)			Patch
M	release/scripts/startup/bl_ui/space_view3d_toolbar.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	source/blender/editors/object/object_intern.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	source/blender/editors/object/object_ops.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	source/blender/editors/object/object_vgroup.c	View	5 chunks	+379 lines, -3 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ideasman42

11 years, 10 months ago (2012-07-13 12:36:22 UTC) #2

looks good to me, one question, but otherwise think this is fine to go into
blender after 2.64's out.

http://codereview.appspot.com/6347064/diff/1/source/blender/editors/object/ob...
File source/blender/editors/object/object_vgroup.c (right):

http://codereview.appspot.com/6347064/diff/1/source/blender/editors/object/ob...
source/blender/editors/object/object_vgroup.c:468: dmesh_src =
mesh_get_derived_deform(scene, ob_src, CD_MASK_BAREMESH | CD_MASK_ORIGINDEX);
do you need origindex? (I dont see it being used) - if so best explain why in a
comment.

Expand All Messages | Collapse All Messages