Issue 6346050: misc/emacs: Fix the gofmt patching when the TMPDIR ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6346050: misc/emacs: Fix the gofmt patching when the TMPDIR ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by jme

Modified:
12 years, 10 months ago

Reviewers:

CC:
Sameer Ajmani, golang-dev

Visibility:
Public.

Description

misc/emacs: Fix the gofmt patching when the TMPDIR is not the default. The previous code assumed the gofmt output referred to /tmp but that's not true if TMPDIR points somewhere else (like on Macs). Fixes issue 3782.

Patch Set 1 #

Patch Set 2 : diff -r 070604630d24 https://code.google.com/p/go/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	misc/emacs/go-mode.el	View	1	6 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sameer Ajmani

12 years, 10 months ago (2012-06-29 16:50:08 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=c5f564efc620 ***

    misc/emacs: Fix the gofmt patching when the TMPDIR is not the default.

The previous code assumed the gofmt output referred to /tmp but
that's not true if TMPDIR points somewhere else (like on Macs).
Fixes issue 3782.

R=sameer
CC=golang-dev
http://codereview.appspot.com/6346050

Committer: Sameer Ajmani <sameer@golang.org>

Expand All Messages | Collapse All Messages