Issue 6343091: code review 6343091: freetype/truetype: variable sized bytecode interpreter ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6343091: code review 6343091: freetype/truetype: variable sized bytecode interpreter ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by nigeltao

Modified:
12 years, 5 months ago

Reviewers:

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype/truetype: variable sized bytecode interpreter stack/store.

Patch Set 2 : diff -r 33f1aeb76b1a https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 33f1aeb76b1a https://code.google.com/p/freetype-go #

Total comments: 2

Patch Set 4 : diff -r 33f1aeb76b1a https://code.google.com/p/freetype-go #

Patch Set 5 : diff -r 33f1aeb76b1a https://code.google.com/p/freetype-go #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -5 lines)			Patch
M	freetype/truetype/hint.go	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download
M	freetype/truetype/hint_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	freetype/truetype/truetype.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

12 years, 5 months ago (2012-07-10 13:34:36 UTC) #1

bsiegert

http://codereview.appspot.com/6343091/diff/2002/freetype/truetype/hint.go File freetype/truetype/hint.go (right): http://codereview.appspot.com/6343091/diff/2002/freetype/truetype/hint.go#newcode31 freetype/truetype/hint.go:31: func (h *hinter) init(f *Font) { Should this be ...

12 years, 5 months ago (2012-07-10 18:18:25 UTC) #2

nigeltao

12 years, 5 months ago (2012-07-11 00:43:48 UTC) #3

nigeltao

12 years, 5 months ago (2012-07-11 11:48:46 UTC) #5

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=6d4d289ee00e ***

freetype/truetype: variable sized bytecode interpreter stack/store.

R=bsiegert
CC=golang-dev
http://codereview.appspot.com/6343091

Expand All Messages | Collapse All Messages