code review 6343091: freetype/truetype: variable sized bytecode interpreter ...

freetype/truetype: variable sized bytecode interpreter stack/store.

[nigeltao, 2012-07-10 13:34:36]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2012-07-10 18:18:25]

http://codereview.appspot.com/6343091/diff/2002/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

http://codereview.appspot.com/6343091/diff/2002/freetype/truetype/hint.go#new...
freetype/truetype/hint.go:31: func (h *hinter) init(f *Font) {
Should this be

func newHinter(f *Font) *hinter

instead?

[nigeltao, 2012-07-11 00:43:48]

http://codereview.appspot.com/6343091/diff/2002/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

http://codereview.appspot.com/6343091/diff/2002/freetype/truetype/hint.go#new...
freetype/truetype/hint.go:31: func (h *hinter) init(f *Font) {
On 2012/07/10 18:18:26, bsiegert wrote:
> Should this be
> 
> func newHinter(f *Font) *hinter
> 
> instead?

No. I'd like to be able to re-use a hinter (and its buffers) with different
fonts and sizes.

[bsiegert, 2012-07-11 05:08:13]

LGTM then.

[nigeltao, 2012-07-11 11:48:46]

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=6d4d289ee00e ***

freetype/truetype: variable sized bytecode interpreter stack/store.

R=bsiegert
CC=golang-dev
http://codereview.appspot.com/6343091