code review 6343047: cmd/dist: Make windows.c's fatal() print to stderr

cmd/dist: Make windows.c's fatal() print to stderr

Generating env.bat using dist env -wp > env.bat failed silently
if case of an error, because the message was redirected to env.bat.
Verbose messages still go to stdout, causing problems, but that's
a seperate change.
Made errprintf() identical to xprintf(), except for the output handle.
Yes, it's duplicate code, but most of the function is unpacking
the argument list and preparing it for WriteFile(), which has to be
done anyway.

[peted, 2012-06-27 11:18:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[brainman, 2012-06-28 04:20:25]

http://codereview.appspot.com/6343047/diff/5001/src/cmd/dist/windows.c
File src/cmd/dist/windows.c (right):

http://codereview.appspot.com/6343047/diff/5001/src/cmd/dist/windows.c#newcod...
src/cmd/dist/windows.c:129: vfprintf(stderr, fmt, arg);
This is different from xprintf does. I would rather have both output to stdout
and stderr go via same code path - use vfprintf for both, or use WriteFile for
both. Perhaps the later, because we all know what it does. I do not know what
vfprintf does. I am concerned about non-ascii output, see
http://code.google.com/p/go/issues/detail?id=3754 for related problem.

Perhaps, you could copy xprintf into a new function and have it take one extra
parameter - output handle. Then you could use that function from both xprintf
and fatal.

[peted, 2012-06-29 13:30:19]

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[brainman, 2012-06-30 14:26:29]

LGTM

Thank you.

Alex

[brainman, 2012-06-30 14:27:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=3f7501fdb220 ***

cmd/dist: Make windows.c's fatal() print to stderr

Generating env.bat using dist env -wp > env.bat failed silently
if case of an error, because the message was redirected to env.bat.
Verbose messages still go to stdout, causing problems, but that's
a seperate change.
Made errprintf() identical to xprintf(), except for the output handle.
Yes, it's duplicate code, but most of the function is unpacking
the argument list and preparing it for WriteFile(), which has to be
done anyway.

R=golang-dev, alex.brainman
CC=golang-dev
http://codereview.appspot.com/6343047

Committer: Alex Brainman <alex.brainman@gmail.com>