Issue 6341046: code review 6341046: flag: fix indexing doc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6341046: code review 6341046: flag: fix indexing doc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dsymonds

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Patch Set 2 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 60041e23de38 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/flag/flag.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-06-24 17:01:30 UTC) #1

http://codereview.appspot.com/6341046/diff/4/src/pkg/flag/flag.go File src/pkg/flag/flag.go (right): http://codereview.appspot.com/6341046/diff/4/src/pkg/flag/flag.go#newcode36 src/pkg/flag/flag.go:36: The arguments are indexed from 0 up to flag.NArg()-1. ...

12 years, 11 months ago (2012-06-24 19:05:29 UTC) #2

dsymonds

12 years, 11 months ago (2012-06-24 19:08:28 UTC) #3

dsymonds

12 years, 11 months ago (2012-06-24 19:23:55 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=6ca4825bc867 ***

flag: fix indexing doc.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6341046

Expand All Messages | Collapse All Messages