Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 6333057: code review 6333057: spec: clarify receive operator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by gri
Modified:
12 years, 11 months ago
Reviewers:
CC:
r, rsc, ken2, iant, dsymonds, golang-dev
Visibility:
Public.

Description

spec: clarify receive operator - receiving from a closed channel returns immediately - in the ,ok form, the 2nd result is of type bool, not just boolean (gc and ggcgo agree). Per dsymonds' suggestion.

Patch Set 1 #

Patch Set 2 : diff -r a95bedca6dae https://code.google.com/p/go #

Patch Set 3 : diff -r a95bedca6dae https://code.google.com/p/go #

Patch Set 4 : diff -r a95bedca6dae https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r a95bedca6dae https://code.google.com/p/go #

Patch Set 6 : diff -r db559a037266 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M doc/go_spec.html View 1 2 3 4 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 7
gri
Hello r@golang.org, rsc@golang.org, ken@golang.org, iant@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change ...
12 years, 11 months ago (2012-06-22 21:55:59 UTC) #1
dsymonds
LGTM FWIW
12 years, 11 months ago (2012-06-22 22:10:33 UTC) #2
r
http://codereview.appspot.com/6333057/diff/6001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6333057/diff/6001/doc/go_spec.html#newcode3188 doc/go_spec.html:3188: <a href="#The_zero_value">zero value</a>. Receiving from a <a href="#Close">closed</a> channel ...
12 years, 11 months ago (2012-06-22 22:19:56 UTC) #3
gri
PTAL. Modified and uploaded. http://codereview.appspot.com/6333057/diff/6001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/6333057/diff/6001/doc/go_spec.html#newcode3188 doc/go_spec.html:3188: <a href="#The_zero_value">zero value</a>. On 2012/06/22 ...
12 years, 11 months ago (2012-06-22 23:39:51 UTC) #4
r
LGTM
12 years, 11 months ago (2012-06-22 23:53:20 UTC) #5
iant
LGTM
12 years, 11 months ago (2012-06-23 00:18:32 UTC) #6
gri
12 years, 11 months ago (2012-06-25 18:28:35 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=c72ac7873261 ***

spec: clarify receive operator

- receiving from a closed channel returns immediately
- in the ,ok form, the 2nd result is of type bool, not
  just boolean (gc and ggcgo agree).

Per dsymonds' suggestion.

R=r, rsc, ken, iant, dsymonds
CC=golang-dev
http://codereview.appspot.com/6333057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b