Issue 6332053: code review 6332053: misc/chrome/gophertool: Support for manifest version 1 ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6332053: code review 6332053: misc/chrome/gophertool: Support for manifest version 1 ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by amir

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

misc/chrome/gophertool: Support for manifest version 1 is being phased out. Manifest version 1 was deprecated in Chrome 18, and support will be phased out according to the schedule available at: http://code.google.com/chrome/extensions/manifestVersion.html

Patch Set 1 #

Patch Set 2 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	misc/chrome/gophertool/manifest.json	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

amir

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-06-24 08:05:24 UTC) #1

rsc

Thanks. Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright Thanks. Russ

12 years, 11 months ago (2012-06-24 23:21:39 UTC) #2

amir

Hi Russ, CLA submitted. Thanks, amir On 2012/06/24 23:21:39, rsc wrote: > Thanks. > > ...

12 years, 11 months ago (2012-06-25 05:51:04 UTC) #3

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=0f017230e6b4 *** misc/chrome/gophertool: Support for manifest version 1 is being phased out. ...

12 years, 11 months ago (2012-06-25 21:19:11 UTC) #4

LGTM

Expand All Messages | Collapse All Messages