Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1029)

Issue 6330046: musicxml2ly: Fix title, chord symbol and midi bugs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Julien Rioux
Modified:
11 years, 10 months ago
Reviewers:
Graham Percival, pl_s
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

musicxml2ly: Fix title, chord symbol and midi bugs. Fix for several musicxml2ly bugs (clean up version of the patch at http://codereview.appspot.com/5697059/): Titles and headers can now contain single words followed by a punctuation mark (.,!:). See issue 1983. Chord symbols are now placed above staffs instead of below. See issue 2537. musicxml2ly now includes an out-commented midi-block in every .ly-file. Docs: Added command line options -m and --midi to Usage Patch by Patrick Schmidt.

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M Documentation/usage/external.itely View 2 chunks +5 lines, -2 lines 0 comments Download
M python/musicexp.py View 1 2 chunks +11 lines, -6 lines 0 comments Download
M python/musicxml.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/musicxml2ly.py View 1 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 1
Graham Percival
11 years, 10 months ago (2012-06-26 06:49:53 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b