code review 6329045: net/http: fix inserting of implicit redirects in serve mux

net/http: fix inserting of implicit redirects in serve mux

In serve mux, if pattern contains a host name, pass only the path to
the redirect handler.

Add tests for serve mux redirections.

[chressie1, 2012-06-21 23:17:52]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-06-21 23:20:49]

This would need a new test or so also.

http://codereview.appspot.com/6329045/diff/2002/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

http://codereview.appspot.com/6329045/diff/2002/src/pkg/net/http/server.go#ne...
src/pkg/net/http/server.go:996: path = pattern[strings.Index(pattern, "/"):]
what if strings.Index returns -1?

[chressie1, 2012-06-21 23:33:59]

On 2012/06/21 23:20:49, bradfitz wrote:
> This would need a new test or so also.
> 
> 
definitely, but I think there are currently no tests for the virtual host name
thing, or did I miss something here? would probably be a different CL then. 

http://codereview.appspot.com/6329045/diff/2002/src/pkg/net/http/server.go
> File src/pkg/net/http/server.go (right):
> 
>
http://codereview.appspot.com/6329045/diff/2002/src/pkg/net/http/server.go#ne...
> src/pkg/net/http/server.go:996: path = pattern[strings.Index(pattern, "/"):]
> what if strings.Index returns -1?

it shouldn't, we have at least the trailing slash.

[chressie1, 2012-06-22 11:21:55]

PTAL

On 2012/06/21 23:20:49, bradfitz wrote:
> This would need a new test or so also.

Done.

[chressie1, 2012-06-29 14:15:55]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[chressie1, 2012-07-22 11:47:26]

PTAL.

1. Documented that strings.Index can't be -1, because the pattern contains at
least one slash.

2. Modified TestHostHandler slightly to support tree redirection tests.

[gobot, 2012-08-07 04:08:51]

R=rsc (assigned by rsc@golang.org)

[chressie1, 2012-08-20 07:01:11]

friendly ping

[bradfitz, 2012-08-20 07:27:51]

ServeMux has historically been

On Mon, Aug 20, 2012 at 5:01 PM, <chressie@gmail.com> wrote:

> friendly ping
>
>
http://codereview.appspot.com/**6329045/<http://codereview.appspot.com/6329045/>
>

[bradfitz, 2012-08-20 07:36:46]

ServeMux has historically been Russ's thing, so I'll let him take it once
he's back and caught up.

On Mon, Aug 20, 2012 at 5:01 PM, <chressie@gmail.com> wrote:

> friendly ping
>
>
http://codereview.appspot.com/**6329045/<http://codereview.appspot.com/6329045/>
>

[rsc, 2012-08-31 15:58:12]

LGTM

[rsc, 2012-08-31 16:00:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=c8cc72708080 ***

net/http: fix inserting of implicit redirects in serve mux

In serve mux, if pattern contains a host name, pass only the path to
the redirect handler.

Add tests for serve mux redirections.

R=rsc
CC=bradfitz, gobot, golang-dev
http://codereview.appspot.com/6329045

Committer: Russ Cox <rsc@golang.org>