code review 6327051: net/rpc: fix typo in documentation, clarify semantics o...

net/rpc: fix typo in documentation, clarify semantics of error return

Several of my students were confused by trying to use both the error
return and a reply return, so I figured it was worth explicitly clarifying
that returning an error overrides the reply.

[dga, 2012-06-22 21:50:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-06-22 21:54:36]

http://codereview.appspot.com/6327051/diff/4001/src/pkg/net/rpc/server.go
File src/pkg/net/rpc/server.go (right):

http://codereview.appspot.com/6327051/diff/4001/src/pkg/net/rpc/server.go#new...
src/pkg/net/rpc/server.go:27: (In the future, these requirements may soften for
custom codecs.)
prefer this as is.

http://codereview.appspot.com/6327051/diff/4001/src/pkg/net/rpc/server.go#new...
src/pkg/net/rpc/server.go:33: will not be sent back to the client.
looks like the indentation is different here. did you use tab or spaces?

[dga, 2012-06-22 21:59:49]

On Friday, June 22, 2012 5:54:36 PM UTC-4, r...@golang.org wrote:
>
>
> http://codereview.appspot.com/6327051/diff/4001/src/pkg/net/rpc/server.go 
> File src/pkg/net/rpc/server.go (right): 
>
>
http://codereview.appspot.com/6327051/diff/4001/src/pkg/net/rpc/server.go#new...

>
>
src/pkg/net/rpc/server.go:27<http://codereview.appspot.com/6327051/diff/4001/src/pkg/net/rpc/server.go#newcode27src/pkg/net/rpc/server.go:27>:

> (In the future, these requirements may 
> soften for custom codecs.) 
> prefer this as is. 
>

Er, the current version is grammatically incorrect:  "In future, these". 
 Should I revert?

>
> : will not be sent back to the client. 
> looks like the indentation is different here. did you use tab or spaces? 
>
> http://codereview.appspot.com/6327051/ 
>

Whoops - spaces.  Fixed to tabs and updated.  Thanks!
 

[r, 2012-06-22 22:06:50]

LGTM

http://codereview.appspot.com/6327051/diff/6001/src/pkg/net/rpc/server.go
File src/pkg/net/rpc/server.go (right):

http://codereview.appspot.com/6327051/diff/6001/src/pkg/net/rpc/server.go#new...
src/pkg/net/rpc/server.go:27: (In the future, these requirements may soften for
custom codecs.)
ok, you can have the 'the'.

[r, 2012-06-22 22:07:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=ef713d7587f2 ***

net/rpc: fix typo in documentation, clarify semantics of error return

Several of my students were confused by trying to use both the error
return and a reply return, so I figured it was worth explicitly clarifying
that returning an error overrides the reply.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6327051

Committer: Rob Pike <r@golang.org>