Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(371)

Issue 6311043: [http #102] google-http-client-protobuf (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by mlinder
Modified:
11 years, 8 months ago
Reviewers:
rmistry, yanivi
Visibility:
Public.

Description

Splits off the protocol buffer part of the http-client project into http-client-protobuf. Submitted in 251:fab4a8efc2c1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated/Added missing references #

Total comments: 6

Patch Set 3 : removed the .extensions part in the package name #

Total comments: 12

Patch Set 4 : Removed files instead of adding deprecation warnings to them #

Total comments: 13

Patch Set 5 : Fixed issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+779 lines, -80 lines) Patch
M google-http-client-assembly/.classpath View 1 1 chunk +1 line, -0 lines 0 comments Download
A google-http-client-assembly/dependencies/protobuf-dependencies.html View 1 1 chunk +101 lines, -0 lines 0 comments Download
M google-http-client-assembly/pom.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M google-http-client-assembly/readme.html View 1 2 3 4 5 chunks +21 lines, -4 lines 0 comments Download
A google-http-client-protobuf/.classpath View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
A google-http-client-protobuf/.project View 1 chunk +29 lines, -0 lines 0 comments Download
A google-http-client-protobuf/.settings/org.eclipse.jdt.core.prefs View 1 2 3 1 chunk +380 lines, -0 lines 0 comments Download
A google-http-client-protobuf/.settings/org.eclipse.jdt.ui.prefs View 1 chunk +120 lines, -0 lines 0 comments Download
A google-http-client-protobuf/pom.xml View 1 chunk +94 lines, -0 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/package-info.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/ProtoObjectParser.java View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/ProtocolBuffers.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/package-info.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-http-client-protobuf/src/test/java/com/google/api/client/protobuf/ProtocolBuffersTest.java View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M google-http-client-protobuf/src/test/protobuf/simple_proto.proto View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
M google-http-client/.classpath View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M google-http-client/pom.xml View 1 2 3 2 chunks +0 lines, -35 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/http/protobuf/ProtoHttpContentTest.java View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
M jdiff.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
M pom.xml View 3 chunks +10 lines, -0 lines 0 comments Download
M release.html View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14
mlinder
This change splits the protobuf parts of the http-client lib into a new google-http-client-protobuf package. ...
11 years, 9 months ago (2012-06-14 19:54:03 UTC) #1
rmistry
Have not completed reviewed yet. But one feedback I wanted to mention: There are more ...
11 years, 9 months ago (2012-06-20 18:58:37 UTC) #2
mlinder
Updated all files I found relevant.
11 years, 9 months ago (2012-06-20 20:54:41 UTC) #3
rmistry
http://codereview.appspot.com/6311043/diff/6001/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): http://codereview.appspot.com/6311043/diff/6001/google-http-client-assembly/readme.html#newcode20 google-http-client-assembly/readme.html:20: <li>google-http-client-appengine is for Google App Engine.</li> Add google-http-client-protobuf here. ...
11 years, 9 months ago (2012-06-21 11:20:57 UTC) #4
rmistry
http://codereview.appspot.com/6311043/diff/6001/release.html File release.html (right): http://codereview.appspot.com/6311043/diff/6001/release.html#newcode106 release.html:106: release.html after that</li> Putting this note in release.html is ...
11 years, 9 months ago (2012-06-21 11:22:34 UTC) #5
mlinder
Updated release.html + readme.html http://codereview.appspot.com/6311043/diff/6001/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): http://codereview.appspot.com/6311043/diff/6001/google-http-client-assembly/readme.html#newcode20 google-http-client-assembly/readme.html:20: <li>google-http-client-appengine is for Google App ...
11 years, 9 months ago (2012-06-21 15:48:22 UTC) #6
rmistry
LGTM
11 years, 9 months ago (2012-06-22 13:20:18 UTC) #7
yanivi
Honestly, I'm not a fan of adding "extensions" into the package name. I only intended ...
11 years, 9 months ago (2012-06-22 13:48:34 UTC) #8
mlinder
I don't have a strong opinion on the 'extensions.' matter, so sure, sounds good. Please ...
11 years, 9 months ago (2012-06-22 17:17:23 UTC) #9
yanivi
http://codereview.appspot.com/6311043/diff/11002/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): http://codereview.appspot.com/6311043/diff/11002/google-http-client-assembly/readme.html#newcode50 google-http-client-assembly/readme.html:50: <li>google-http-client-android3-${project.version}.jar (only for SDK >= 3.0)</li> also add google-http-client-protobuf ...
11 years, 9 months ago (2012-07-03 18:16:19 UTC) #10
mlinder
Changes in this CL: M google-http-client-assembly/.classpath M google-http-client-assembly/pom.xml M google-http-client-assembly/readme.html M google-http-client/pom.xml M jdiff.xml M ...
11 years, 9 months ago (2012-07-03 19:16:38 UTC) #11
yanivi
LGTM http://codereview.appspot.com/6311043/diff/24001/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): http://codereview.appspot.com/6311043/diff/24001/google-http-client-assembly/readme.html#newcode55 google-http-client-assembly/readme.html:55: <li>google-http-client-protobuf-${project.version}.jar (when using ProtoObjectParser)</li> "when using protobuf-java" similarly ...
11 years, 9 months ago (2012-07-03 20:00:18 UTC) #12
mlinder
http://codereview.appspot.com/6311043/diff/24001/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): http://codereview.appspot.com/6311043/diff/24001/google-http-client-assembly/readme.html#newcode55 google-http-client-assembly/readme.html:55: <li>google-http-client-protobuf-${project.version}.jar (when using ProtoObjectParser)</li> On 2012/07/03 20:00:18, yanivi wrote: ...
11 years, 8 months ago (2012-07-09 14:23:27 UTC) #13
yanivi
11 years, 8 months ago (2012-07-09 20:01:55 UTC) #14
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b