This change splits the protobuf parts of the http-client lib into a new google-http-client-protobuf package. ...
11 years, 9 months ago
(2012-06-14 19:54:03 UTC)
#1
This change splits the protobuf parts of the http-client lib into a new
google-http-client-protobuf package. Old implementation in the http client has
been marked as deprecated.
http://codereview.appspot.com/6311043/diff/1/google-http-client-protobuf/src/...
File
google-http-client-protobuf/src/main/java/com/google/api/client/extensions/protobuf/ProtocolBuffers.java
(right):
http://codereview.appspot.com/6311043/diff/1/google-http-client-protobuf/src/...
google-http-client-protobuf/src/main/java/com/google/api/client/extensions/protobuf/ProtocolBuffers.java:34:
* @author Yaniv Inbar
Should those versions be updated or left at their old ver?
Have not completed reviewed yet. But one feedback I wanted to mention: There are more ...
11 years, 9 months ago
(2012-06-20 18:58:37 UTC)
#2
Have not completed reviewed yet. But one feedback I wanted to mention:
There are more files that need to be modified when you create a new artifact.
Files like-
release.html
jdiff.xml
google-http-client-assembly/readme.html
google-http-client-assembly/.classpath
google-http-client-assembly/dependencies/...
There may be a few more as well, one way to check is to do a grep for an old
artifact 'google-http-client-android2' and check for where it shows up.
Also, after this CL does in there will similarly be a few files in the generator
that will have to be updated.
Also, when the new version of google-http-java-client is released we will have
to update:
http://code.google.com/p/google-http-java-client/wiki/Setup
http://codereview.appspot.com/6311043/diff/6001/release.html File release.html (right): http://codereview.appspot.com/6311043/diff/6001/release.html#newcode106 release.html:106: release.html after that</li> Putting this note in release.html is ...
11 years, 9 months ago
(2012-06-21 11:22:34 UTC)
#5
Honestly, I'm not a fan of adding "extensions" into the package name. I only intended ...
11 years, 9 months ago
(2012-06-22 13:48:34 UTC)
#8
Honestly, I'm not a fan of adding "extensions" into the package name. I only
intended to be use for platform-specific packages, e.g. Android or Google App
Engine. My preference would be to keep the existing package naming, and simply
hg mv the existing files.
Changes in this CL: M google-http-client-assembly/.classpath M google-http-client-assembly/pom.xml M google-http-client-assembly/readme.html M google-http-client/pom.xml M jdiff.xml M ...
11 years, 9 months ago
(2012-07-03 19:16:38 UTC)
#11
Changes in this CL:
M google-http-client-assembly/.classpath
M google-http-client-assembly/pom.xml
M google-http-client-assembly/readme.html
M google-http-client/pom.xml
M jdiff.xml
M pom.xml
M release.html
A google-http-client-assembly/dependencies/protobuf-dependencies.html
A google-http-client-protobuf/.classpath
A google-http-client-protobuf/.project
A google-http-client-protobuf/.settings/org.eclipse.jdt.core.prefs
A google-http-client-protobuf/.settings/org.eclipse.jdt.ui.prefs
A google-http-client-protobuf/pom.xml
A
google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java
A
google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/package-info.java
A
google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/ProtoObjectParser.java
A
google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/ProtocolBuffers.java
A
google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/package-info.java
A
google-http-client-protobuf/src/test/java/com/google/api/client/extensions/protobuf/ProtocolBuffersTest.java
A google-http-client-protobuf/src/test/protobuf/simple_proto.proto
R
google-http-client/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java
R
google-http-client/src/main/java/com/google/api/client/http/protobuf/package-info.java
R
google-http-client/src/main/java/com/google/api/client/protobuf/ProtoObjectParser.java
R
google-http-client/src/main/java/com/google/api/client/protobuf/ProtocolBuffers.java
R
google-http-client/src/main/java/com/google/api/client/protobuf/package-info.java
R
google-http-client/src/test/java/com/google/api/client/http/protobuf/ProtoHttpContentTest.java
R
google-http-client/src/test/java/com/google/api/client/protobuf/ProtocolBuffersTest.java
http://codereview.appspot.com/6311043/diff/11002/google-http-client-assembly/...
File google-http-client-assembly/readme.html (right):
http://codereview.appspot.com/6311043/diff/11002/google-http-client-assembly/...
google-http-client-assembly/readme.html:50:
<li>google-http-client-android3-${project.version}.jar (only for SDK >=
3.0)</li>
On 2012/07/03 18:16:19, yanivi wrote:
> also add google-http-client-protobuf
> similarly below
Done. Please confirm that this is how you expect it to be.
http://codereview.appspot.com/6311043/diff/11002/google-http-client-protobuf/...
File google-http-client-protobuf/.classpath (right):
http://codereview.appspot.com/6311043/diff/11002/google-http-client-protobuf/...
google-http-client-protobuf/.classpath:8:
path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.6"
/>
On 2012/07/03 18:16:19, yanivi wrote:
> <classpathentry kind="con"
>
>
path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/J2SE-1.5"
> />
Done.
http://codereview.appspot.com/6311043/diff/11002/google-http-client-protobuf/...
File google-http-client-protobuf/.settings/org.eclipse.jdt.core.prefs (right):
http://codereview.appspot.com/6311043/diff/11002/google-http-client-protobuf/...
google-http-client-protobuf/.settings/org.eclipse.jdt.core.prefs:14:
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.6
On 2012/07/03 18:16:19, yanivi wrote:
> 1.6 -> 1.5
>
> similarly below
Done.
http://codereview.appspot.com/6311043/diff/11002/google-http-client-protobuf/...
File
google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java
(right):
http://codereview.appspot.com/6311043/diff/11002/google-http-client-protobuf/...
google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java:49:
public class ProtoHttpContent extends AbstractHttpContent {
On 2012/07/03 18:16:19, yanivi wrote:
> please instead make this an "hg mv".
Done.
http://codereview.appspot.com/6311043/diff/11002/google-http-client/pom.xml
File google-http-client/pom.xml (right):
http://codereview.appspot.com/6311043/diff/11002/google-http-client/pom.xml#n...
google-http-client/pom.xml:75: <!-- TODO(mlinder): Remove this execution block
in 1.12 -->
On 2012/07/03 18:16:19, yanivi wrote:
> please provide an explanation why this block needs to be removed
>
> similarly below
Done.
http://codereview.appspot.com/6311043/diff/11002/google-http-client/src/main/...
File
google-http-client/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java
(right):
http://codereview.appspot.com/6311043/diff/11002/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java:50:
@Deprecated
On 2012/07/03 18:16:19, yanivi wrote:
> Please don't deprecate but instead remove these files. It is a requirement
that
> none of our jars contain the same classes in order to support OSGi. It is
also
> required to support MOE. Besides, we don't want developers to think that
> com.google.api.client.protobuf.ProtoHttpContent is deprecated. It isn't
> deprecated. It was just moved to a different jar.
>
> similarly for the other deprecated classes.
Done.
Issue 6311043: [http #102] google-http-client-protobuf
(Closed)
Created 11 years, 9 months ago by mlinder
Modified 11 years, 8 months ago
Reviewers: yanivi, rmistry
Base URL:
Comments: 32