Issue 6306076: code review 6306076: go/build: fix boolean negation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306076: code review 6306076: go/build: fix boolean negation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, bsiegert

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 267090160633 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 267090160633 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c8d163b7930e https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/go/build/doc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-06-13 19:49:10 UTC) #1

rsc

13 years, 2 months ago (2012-06-13 20:25:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cbef2fd0bcda ***

go/build: fix boolean negation

!(linux&cgo | darwin&cgo)
= (!linux|!cgo) & (!darwin|!cgo)
= (!linux&!darwin) | !cgo  // new comment
≠ !linux | !darwin | !cgo  // old comment

Fixes issue 3726.

R=golang-dev, bsiegert
CC=golang-dev
http://codereview.appspot.com/6306076

Expand All Messages | Collapse All Messages