Issue 6306063: Foobar theme usersettings template added.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306063: Foobar theme usersettings template added.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by jaiditya

Modified:
11 years, 11 months ago

Reviewers:
Reimar Bauer

Visibility:
Public.

More Reviews

Description

Foobar theme usersettings template added.

Patch Set 2 : Added 'moin-' prefix to ids #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -0 lines)			Patch
	A	MoinMoin/themes/foobar/templates/usersettings.html	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reimar Bauer

http://codereview.appspot.com/6306063/diff/1/MoinMoin/themes/foobar/templates/usersettings.html File MoinMoin/themes/foobar/templates/usersettings.html (right): http://codereview.appspot.com/6306063/diff/1/MoinMoin/themes/foobar/templates/usersettings.html#newcode24 MoinMoin/themes/foobar/templates/usersettings.html:24: <div id="password" class="moin-tab-body moin-form"> please prefix all id by ...

11 years, 11 months ago (2012-06-11 08:37:37 UTC) #1

jaiditya

11 years, 11 months ago (2012-06-11 22:53:03 UTC) #2

http://codereview.appspot.com/6306063/diff/1/MoinMoin/themes/foobar/templates...
File MoinMoin/themes/foobar/templates/usersettings.html (right):

http://codereview.appspot.com/6306063/diff/1/MoinMoin/themes/foobar/templates...
MoinMoin/themes/foobar/templates/usersettings.html:24: <div id="password"
class="moin-tab-body moin-form">
On 2012/06/11 08:37:37, Reimar Bauer wrote:
> please prefix all id by moin-
> 
> the idea is to get them clear separated from 3rd party theme extensions

ok

Expand All Messages | Collapse All Messages