Issue 6306062: Foobar theme popup styling

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by jaiditya

Modified:
11 years, 11 months ago

Reviewers:
waldi, Reimar Bauer

Visibility:
Public.

More Reviews

Patch Set 3 : Foobar theme popup-closer button #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
M	MoinMoin/themes/foobar/static/css/common.css	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	MoinMoin/themes/foobar/static/css/stylus/main.styl	View	1 2	1 chunk	+6 lines, -5 lines	0 comments	Download
R	MoinMoin/themes/foobar/static/img/close_icon.png	View	1 2	Binary file		0 comments	Download
M	MoinMoin/themes/foobar/templates/index.html	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Reimar Bauer

please use a prefix moin- http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/css/common.css File MoinMoin/themes/foobar/static/css/common.css (right): http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/css/common.css#newcode6 MoinMoin/themes/foobar/static/css/common.css:6: License: GNU GPL v2 ...

11 years, 11 months ago (2012-06-11 08:44:38 UTC) #1

waldi

http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/css/common.css File MoinMoin/themes/foobar/static/css/common.css (right): http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/css/common.css#newcode1 MoinMoin/themes/foobar/static/css/common.css:1: /* common.css - MoinMoin Default Styles So this is ...

11 years, 11 months ago (2012-06-11 09:51:26 UTC) #2

jaiditya

11 years, 11 months ago (2012-06-11 22:49:40 UTC) #3

http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/cs...
File MoinMoin/themes/foobar/static/css/stylus/main.styl (right):

http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/cs...
MoinMoin/themes/foobar/static/css/stylus/main.styl:181: background: transparent
url("../img/moin-transparent-bg.png") repeat
On 2012/06/11 09:51:26, waldi wrote:
> Why does this need a picture?

this picture separates the popup from the background. Its a translucent box
behind the popup

http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/static/cs...
MoinMoin/themes/foobar/static/css/stylus/main.styl:214: display: block
On 2012/06/11 09:51:26, waldi wrote:
> Why have popup a different form style than normal forms?

normal forms are not in good style yet.

http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/templates...
File MoinMoin/themes/foobar/templates/index.html (left):

http://codereview.appspot.com/6306062/diff/1/MoinMoin/themes/foobar/templates...
MoinMoin/themes/foobar/templates/index.html:136: <div class="popup-closer
popup-cancel" title="{{ _("Close") }}">x</div>
On 2012/06/11 08:44:38, Reimar Bauer wrote:
> please use a prefix moin-

ok.

Expand All Messages | Collapse All Messages