Issue 6304077: code review 6304077: freetype: optimize []byte to uint16/uint32 conversions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6304077: code review 6304077: freetype: optimize []byte to uint16/uint32 conversions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by nigeltao

Modified:
12 years, 5 months ago

Reviewers:

CC:
rsc, r, golang-dev, jra

Visibility:
Public.

Description

freetype: optimize []byte to uint16/uint32 conversions. Thanks to Jeff R. Allen <jra@nella.org> for the conversation that led to this change. benchmark old ns/op new ns/op delta BenchmarkDrawString 21168440 20143860 -4.84% The number of mallocs per iteration is unchanged.

Patch Set 1 #

Patch Set 2 : diff -r 3eb9f09ecbb1 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 3eb9f09ecbb1 https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 3eb9f09ecbb1 https://code.google.com/p/freetype-go #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -125 lines)			Patch
A	freetype/freetype_test.go	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download
M	freetype/truetype/glyph.go	View	1	6 chunks	+47 lines, -38 lines	0 comments	Download
M	freetype/truetype/truetype.go	View	1	12 chunks	+59 lines, -87 lines	0 comments	Download
A	freetype/truetype/truetype_test.go	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, jra@nella.org), I'd like you to review this change to https://code.google.com/p/freetype-go

12 years, 5 months ago (2012-06-14 04:33:20 UTC) #1

nigeltao

12 years, 5 months ago (2012-06-16 02:20:54 UTC) #3

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=12c254407319 ***

freetype: optimize []byte to uint16/uint32 conversions.

Thanks to Jeff R. Allen <jra@nella.org> for the conversation that
led to this change.

benchmark              old ns/op    new ns/op    delta
BenchmarkDrawString     21168440     20143860   -4.84%

The number of mallocs per iteration is unchanged.

R=rsc, r
CC=golang-dev, jra
http://codereview.appspot.com/6304077

Expand All Messages | Collapse All Messages