Issue 6303099: code review 6303099: go/ast: multiple "blank" imports are permitted

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6303099: code review 6303099: go/ast: multiple "blank" imports are permitted (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by gri

Modified:
11 years, 10 months ago

Reviewers:

CC:
rsc, dsymonds, golang-dev

Visibility:
Public.

Description

go/ast: multiple "blank" imports are permitted

Patch Set 2 : diff -r 95dddad64860 https://code.google.com/p/go #

Patch Set 3 : diff -r 95dddad64860 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r a3c2d3c41c45 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a3c2d3c41c45 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r a3c2d3c41c45 https://go.googlecode.com/hg/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
M	src/pkg/exp/types/check_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/types/testdata/test0.src	View	1 2 3 4	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/pkg/go/ast/resolve.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2012-06-18 23:52:30 UTC) #1

dsymonds

http://codereview.appspot.com/6303099/diff/5001/src/pkg/exp/types/testdata/test0.src File src/pkg/exp/types/testdata/test0.src (right): http://codereview.appspot.com/6303099/diff/5001/src/pkg/exp/types/testdata/test0.src#newcode13 src/pkg/exp/types/testdata/test0.src:13: _ "math" should probably also check that you can ...

11 years, 10 months ago (2012-06-19 02:49:14 UTC) #2

rsc

LGTM Agree with dsymonds about changing the second "math" to something else.

11 years, 10 months ago (2012-06-19 04:33:37 UTC) #3

gri

will do before submitting. can't hurt down the road, but doesn't matter in this case. ...

11 years, 10 months ago (2012-06-19 04:51:08 UTC) #4

gri

11 years, 10 months ago (2012-06-19 04:56:53 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=2033e1b11a20 ***

go/ast: multiple "blank" imports are permitted

R=rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/6303099

Expand All Messages | Collapse All Messages