Issue 6303062: Foobar theme usersettings title list removed from content.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6303062: Foobar theme usersettings title list removed from content.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by jaiditya

Modified:
11 years, 11 months ago

Reviewers:
Reimar Bauer

Visibility:
Public.

More Reviews

Description

Foobar theme usersettings title list removed from content.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correction-changed px to em #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	MoinMoin/themes/foobar/static/css/common.css	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	MoinMoin/themes/foobar/static/css/stylus/main.styl	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Reimar Bauer

11 years, 11 months ago (2012-06-11 08:41:01 UTC) #1

http://codereview.appspot.com/6303062/diff/1/MoinMoin/themes/foobar/static/cs...
File MoinMoin/themes/foobar/static/css/common.css (right):

http://codereview.appspot.com/6303062/diff/1/MoinMoin/themes/foobar/static/cs...
MoinMoin/themes/foobar/static/css/common.css:175:
.moin-tab-titles{margin:-6px;list-style:none}
px or em?

We need a guideline where or when to use em and or px

Expand All Messages | Collapse All Messages