code review 6300058: misc/dashboard/app: fix build failure notifications

misc/dashboard/app: fix build failure notifications

The datastore.Query methods once mutated the Query value, but now they return
a derivative query, so the Hash= and ParentHash= filters were not being
applied.

[adg, 2012-06-06 23:22:54]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-06-06 23:25:26]

LGTM

On Wed, Jun 6, 2012 at 4:22 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
>      misc/dashboard/app: fix build failure notifications
>
> The datastore.Query methods once mutated the Query value, but now they
> return
> a derivative query, so the Hash= and ParentHash= filters were not being
> applied.
>
> Please review this at
http://codereview.appspot.com/**6300058/<http://codereview.appspot.com/6300058/>
>
> Affected files:
>  M misc/dashboard/app/build/**notify.go
>
>
> Index: misc/dashboard/app/build/**notify.go
> ==============================**==============================**=======
> --- a/misc/dashboard/app/build/**notify.go
> +++ b/misc/dashboard/app/build/**notify.go
> @@ -45,7 +45,7 @@
>        if cr.OK {
>                // This commit is OK. Notify if next Commit is broken.
>                next := new(Commit)
> -               q.Filter("ParentHash=", com.Hash)
> +               q = q.Filter("ParentHash=", com.Hash)
>                if err := firstMatch(c, q, next); err != nil {
>                        if err == datastore.ErrNoSuchEntity {
>                                // OK at tip, no notification necessary.
> @@ -61,7 +61,7 @@
>        } else {
>                // This commit is broken. Notify if the previous Commit is
> OK.
>                prev := new(Commit)
> -               q.Filter("Hash=", com.ParentHash)
> +               q = q.Filter("Hash=", com.ParentHash)
>                if err := firstMatch(c, q, prev); err != nil {
>                        if err == datastore.ErrNoSuchEntity {
>                                // No previous result, let the backfill of
>
>
>

[dsymonds, 2012-06-06 23:27:05]

LGTM

[adg, 2012-06-06 23:27:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=ff2e12aef85e ***

      misc/dashboard/app: fix build failure notifications

The datastore.Query methods once mutated the Query value, but now they return
a derivative query, so the Hash= and ParentHash= filters were not being
applied.

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
http://codereview.appspot.com/6300058