Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(171)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6299055: code review 6299055: cmd/gc: fix LEAQ $0, SI bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by rsc
Modified:
12 years, 11 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: fix LEAQ $0, SI bug Cannot take effective address of constant. Fixes issue 3670.

Patch Set 1 #

Patch Set 2 : diff -r b720fc58b147 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b720fc58b147 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/cmd/gc/gen.c View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A test/fixedbugs/bug444.go View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2012-06-07 15:59:17 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=c4a344d25b87 *** cmd/gc: fix LEAQ $0, SI bug Cannot take effective address ...
12 years, 11 months ago (2012-06-07 15:59:26 UTC) #2
ken3
12 years, 11 months ago (2012-06-07 19:05:06 UTC) #3 
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b