Removing enableGZipContent from GoogleClient

Depends on CL http://codereview.appspot.com/6297045/.

[yanivi, 2012-06-05 19:48:04]

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
File
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java
(right):

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java:77:
HttpTransport transport, JsonFactory jsonFactory, String rootUrl, String
servicePath) {
protected, since we don't anticipate anyone using GoogleClient directly

add HttpRequestInitializer parameter to the constructor

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java:238:
public static Builder builder(
why don't we just remove this builder?

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java:291:
HttpTransport transport, JsonFactory jsonFactory, GenericUrl rootUrl, String
servicePath) {
HttpRequestInitializer parameter

[rmistry, 2012-06-06 12:05:25]

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
File
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java
(right):

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java:77:
HttpTransport transport, JsonFactory jsonFactory, String rootUrl, String
servicePath) {
On 2012/06/05 19:48:04, yanivi wrote:
> protected, since we don't anticipate anyone using GoogleClient directly
> 
> add HttpRequestInitializer parameter to the constructor

I like the pattern of having a public constructor for required params and
builder for optional params. Lets leave GoogleClient accessible incase users
find/have found a reason to use it.

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java:238:
public static Builder builder(
On 2012/06/05 19:48:04, yanivi wrote:
> why don't we just remove this builder?

Done.

http://codereview.appspot.com/6299045/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java:291:
HttpTransport transport, JsonFactory jsonFactory, GenericUrl rootUrl, String
servicePath) {
On 2012/06/05 19:48:04, yanivi wrote:
> HttpRequestInitializer parameter

Done.

[rmistry, 2012-06-06 13:34:16]

hg pull -u

[yanivi, 2012-06-06 15:49:58]

see my comments to the http project

[rmistry, 2012-06-06 19:17:26]

On 2012/06/06 15:49:58, yanivi wrote:
> see my comments to the http project

Applied all comments from the http project. Please take another look.

[yanivi, 2012-06-06 21:29:01]

LGTM