Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 6298073: code review 6298073: goprotobuf: Introduce new proto.Message type. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by dsymonds
Modified:
13 years, 4 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

goprotobuf: Introduce new proto.Message type. Every generated protocol buffer type now implements the proto.Message interface, which means we can add some compile-time type safety throughout the API as well as drop a bunch of error cases.

Patch Set 1 #

Patch Set 2 : diff -r bb0967d56eb1 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r bb0967d56eb1 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r bb0967d56eb1 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -99 lines) Patch
M proto/all_test.go View 1 4 chunks +9 lines, -17 lines 0 comments Download
M proto/clone.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M proto/decode.go View 1 3 chunks +5 lines, -3 lines 0 comments Download
M proto/encode.go View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M proto/equal.go View 1 4 chunks +4 lines, -5 lines 0 comments Download
M proto/equal_test.go View 1 3 chunks +15 lines, -3 lines 0 comments Download
M proto/extensions.go View 1 4 chunks +4 lines, -3 lines 0 comments Download
M proto/lib.go View 1 2 3 chunks +12 lines, -6 lines 0 comments Download
M proto/message_set.go View 1 4 chunks +11 lines, -4 lines 0 comments Download
M proto/properties.go View 1 2 chunks +7 lines, -7 lines 0 comments Download
M proto/testdata/test.pb.go View 1 22 chunks +22 lines, -0 lines 0 comments Download
M proto/text.go View 1 3 chunks +8 lines, -22 lines 0 comments Download
M proto/text_parser.go View 1 2 chunks +3 lines, -8 lines 0 comments Download
M proto/text_test.go View 1 1 chunk +0 lines, -9 lines 0 comments Download
M protoc-gen-go/descriptor/descriptor.pb.go View 1 18 chunks +18 lines, -0 lines 0 comments Download
M protoc-gen-go/generator/generator.go View 1 3 chunks +4 lines, -1 line 0 comments Download
M protoc-gen-go/plugin/plugin.pb.go View 1 3 chunks +3 lines, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go View 1 6 chunks +6 lines, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go.golden View 1 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
13 years, 5 months ago (2012-06-13 05:23:21 UTC) #1
rsc
LGTM Are there any parts that differ from the internal version and would merit closer ...
13 years, 4 months ago (2012-06-13 17:46:07 UTC) #2
dsymonds
On Thu, Jun 14, 2012 at 3:45 AM, Russ Cox <rsc@golang.org> wrote: > Are there ...
13 years, 4 months ago (2012-06-13 23:44:52 UTC) #3
dsymonds
13 years, 4 months ago (2012-06-13 23:45:32 UTC) #4
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=6a3d154261b5 ***

goprotobuf: Introduce new proto.Message type.

Every generated protocol buffer type now implements the proto.Message interface,
which means we can add some compile-time type safety throughout the API
as well as drop a bunch of error cases.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/6298073
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b