Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(699)

Issue 6296093: [cxx-conversion] Remove option to build without a C++ compiler

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Diego Novillo
Modified:
12 years, 10 months ago
Reviewers:
richard.guenther, stevenb.gcc
CC:
iant2, gcc-patches_gcc.gnu.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -853 lines) Patch
M ChangeLog.cxx-conversion View 1 chunk +8 lines, -0 lines 0 comments Download
M Makefile.in View 8 chunks +6 lines, -28 lines 0 comments Download
M Makefile.tpl View 3 chunks +1 line, -8 lines 0 comments Download
M configure View 9 chunks +7 lines, -81 lines 0 comments Download
M configure.ac View 6 chunks +7 lines, -54 lines 0 comments Download
M gcc/ChangeLog.cxx-conversion View 1 chunk +9 lines, -0 lines 0 comments Download
M gcc/Makefile.in View 5 chunks +0 lines, -31 lines 0 comments Download
M gcc/config.in View 1 chunk +0 lines, -6 lines 0 comments Download
M gcc/configure View 12 chunks +14 lines, -245 lines 0 comments Download
M gcc/configure.ac View 3 chunks +8 lines, -28 lines 0 comments Download
gcc/doc/install.texi View 1 chunk +0 lines, -10 lines 0 comments Download
A gcc/go/ChangeLog.cxx-conversion View 1 chunk +5 lines, -0 lines 0 comments Download
M gcc/go/go-c.h View 2 chunks +0 lines, -13 lines 0 comments Download
M gcc/go/go-gcc.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gcc/go/go-system.h View 2 chunks +0 lines, -9 lines 0 comments Download
M gcc/go/gofrontend/expressions.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M gcc/go/gofrontend/gogo-tree.cc View 2 chunks +1 line, -10 lines 0 comments Download
M gcc/go/gofrontend/types.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M libcpp/ChangeLog.cxx-conversion View 1 chunk +6 lines, -0 lines 0 comments Download
M libcpp/Makefile.in View 1 chunk +0 lines, -7 lines 0 comments Download
M libcpp/configure View 10 chunks +7 lines, -279 lines 0 comments Download
M libcpp/configure.ac View 3 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 5
Diego Novillo
Remove option to build without a C++ compiler. This patch removes all the configuration code ...
12 years, 10 months ago (2012-06-19 23:08:36 UTC) #1
iant2
dnovillo@google.com (Diego Novillo) writes: > Ian, could you please take a look to double check ...
12 years, 10 months ago (2012-06-20 13:57:48 UTC) #2
stevenb.gcc
On Wed, Jun 20, 2012 at 1:08 AM, Diego Novillo <dnovillo@google.com> wrote: > diff --git ...
12 years, 10 months ago (2012-06-20 14:10:44 UTC) #3
richard.guenther_gmail.com
On Wed, Jun 20, 2012 at 4:10 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote: > On Wed, ...
12 years, 10 months ago (2012-06-20 14:15:56 UTC) #4
Diego Novillo
12 years, 10 months ago (2012-06-20 15:04:42 UTC) #5
On 12-06-20 10:10 , Steven Bosscher wrote:

>> -# By default, C is the only stage 1 language.
>> +# By default, C and C++ are the only stage 1 languages.
>>   stage1_languages=,c,
>
> So shouldn't you add c++ here?

That was a bad change on the comment.  We only need C for stage1. 
Thanks for spotting it.

>> -  # If bootstrapping, then using --enable-build-with-cxx or
>> -  # --enable-build-poststage1-with-cxx requires enabling C++.
>> -  case
",$enable_languages,:,$ENABLE_BUILD_WITH_CXX,$ENABLE_BUILD_POSTSTAGE1_WITH_CXX,:$enable_bootstrap"
in
>> -    *,c++,*:*:*) ;;
>> -    *:*,yes,*:yes)
>> +  # If bootstrapping, C++ must be enabled.
>
> Hmn, perhaps I misunderstand, but shouldn't C++ also be enabled if not
> bootstrapping?

It's only needed if we are building C++ code.  Everything else uses the 
host compiler.


> You can also remove the lang_requires_boot_languages machinery again.
> It is only used by Go to enable c++ for bootstrapping the Go front
> end, but with c++ enabled by default, there is no need for this hack
> for Go anymore.

Good point.  I'll send a separate patch for that.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b