Issue 6294093: code review 6294093: net/http: fix doc inaccuracy and typo; tighten test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6294093: code review 6294093: net/http: fix doc inaccuracy and typo; tighten test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bradfitz

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

net/http: fix doc inaccuracy and typo; tighten test Note url.Error wrapping, and s/issue/issuing/. Fixes issue 3724

Patch Set 1 #

Patch Set 2 : diff -r 305f67dc3f99 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 305f67dc3f99 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 305f67dc3f99 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/pkg/net/http/client.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/client_test.go	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 11 months ago (2012-06-19 23:22:28 UTC) #1

dsymonds

On Tue, Jun 19, 2012 at 4:22 PM, <bradfitz@golang.org> wrote: > net/url: fix doc inaccuracy ...

12 years, 11 months ago (2012-06-19 23:28:54 UTC) #2

bradfitz

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 11 months ago (2012-06-20 16:23:12 UTC) #3

bradfitz

12 years, 11 months ago (2012-06-24 17:41:38 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=60041e23de38 ***

net/http: fix doc inaccuracy and typo; tighten test

Note url.Error wrapping, and s/issue/issuing/.

Fixes issue 3724

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6294093

Expand All Messages | Collapse All Messages