Issue 6294073: Use LimitInputStream in MediaHttpUploader.setContentAndHeadersOnCurrentRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6294073: Use LimitInputStream in MediaHttpUploader.setContentAndHeadersOnCurrentRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rmistry

Modified:
11 years, 10 months ago

Reviewers:
yanivi

Base URL:
https://google-api-java-client.googlecode.com/hg/

Visibility:
Public.

Description

To fix http://code.google.com/p/google-api-java-client/issues/detail?id=521 : Resumable upload fails when writing multiple chunks.

Patch Set 2 : Added TODO #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	google-api-client/src/main/java/com/google/api/client/googleapis/MediaHttpUploader.java	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

yanivi

http://codereview.appspot.com/6294073/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java File google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java (right): http://codereview.appspot.com/6294073/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java#newcode373 google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java:373: new LimitInputStream(contentInputStream, blockSize)); is it possible to add a ...

11 years, 10 months ago (2012-06-14 20:27:14 UTC) #2

rmistry

11 years, 10 months ago (2012-06-15 11:21:35 UTC) #3

yanivi

11 years, 10 months ago (2012-06-15 11:58:21 UTC) #4

LGTM

As we discussed, you tried it out with Google Drive and the fix works.  So I am
satisfied from a testing point of view.

Expand All Messages | Collapse All Messages