Issue 6294045: code review 6294045: snappy: fix (1) encoding a 0-length input returned garb...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6294045: code review 6294045: snappy: fix (1) encoding a 0-length input returned garb... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by nigeltao

Modified:
11 years, 11 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

snappy: fix (1) encoding a 0-length input returned garbage, and (2) decoding into an existing buffer returned excess bytes.

Patch Set 2 : diff -r 238603884b53 https://code.google.com/p/snappy-go #

Patch Set 3 : diff -r 238603884b53 https://code.google.com/p/snappy-go #

Total comments: 1

Patch Set 4 : diff -r 238603884b53 https://code.google.com/p/snappy-go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
M	snappy/decode.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	snappy/encode.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	snappy/snappy_test.go	View	1	4 chunks	+19 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/snappy-go

11 years, 11 months ago (2012-06-06 06:35:36 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/6294045/diff/3001/snappy/snappy_test.go File snappy/snappy_test.go (right): http://codereview.appspot.com/6294045/diff/3001/snappy/snappy_test.go#newcode38 snappy/snappy_test.go:38: for _, ebuf := range [][]byte{nil, make([]byte, 20), ...

11 years, 11 months ago (2012-06-06 06:40:39 UTC) #2

nigeltao

11 years, 11 months ago (2012-06-06 09:42:25 UTC) #3

*** Submitted as http://code.google.com/p/snappy-go/source/detail?r=e70163b7ede0
***

snappy: fix (1) encoding a 0-length input returned garbage, and
(2) decoding into an existing buffer returned excess bytes.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/6294045

Expand All Messages | Collapse All Messages