Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6279046: Non-modal menus

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by Vino
Modified:
11 years, 11 months ago
Reviewers:
bf-codereview, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

My goal was to solve the problem of when the user has one menu open clicking to open another menu closes the current menu instead of opening the new one. This is because all temporary regions are modal. This patch removes the modality of temporary regions and fixes some problems associated with scrolling and input for the newly non-modal regions. Here's the result: http://www.youtube.com/watch?v=mY_e1gbfZt0 The previous solution for color pickers was to make the menu close when the mouse hovered over another button. I think this is only addresses the symptom of the real problem. If the color picker were non-modal then the mouse would be able to click other buttons with the color picker open. I recognize this code is experimental so I'd like some help in identifying problems that may be created by it.

Patch Set 1 #

Patch Set 2 : Fixes the issue with text areas. #

Total comments: 1

Patch Set 3 : Don't lose the return value from this call to ui_handle_button_event. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M . View 1 2 0 chunks +0 lines, -0 lines 0 comments Download
M source/blender/editors/interface/interface_handlers.c View 1 2 8 chunks +30 lines, -9 lines 0 comments Download
M source/blender/windowmanager/intern/wm_event_system.c View 1 2 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8
Vino
11 years, 11 months ago (2012-06-02 17:54:15 UTC) #1
brechtvl
This patch seems to break text input, numbers get typed twice, and if I press ...
11 years, 11 months ago (2012-06-03 10:20:59 UTC) #2
Vino
Thank you for reviewing! Bugs to fix, sounds fun. New patch on the way.
11 years, 11 months ago (2012-06-03 17:54:05 UTC) #3
Vino
11 years, 11 months ago (2012-06-05 23:30:09 UTC) #4
Vino
On 2012/06/05 23:30:09, Vino wrote: Bugs are now fixed. Text areas should behave normally.
11 years, 11 months ago (2012-06-05 23:59:08 UTC) #5
brechtvl
http://codereview.appspot.com/6279046/diff/5001/source/blender/editors/interface/interface_handlers.c File source/blender/editors/interface/interface_handlers.c (right): http://codereview.appspot.com/6279046/diff/5001/source/blender/editors/interface/interface_handlers.c#newcode6562 source/blender/editors/interface/interface_handlers.c:6562: ui_handle_button_event(C, event, but); With this call to ui_handle_button_event the ...
11 years, 11 months ago (2012-06-06 12:51:39 UTC) #6
Vino
11 years, 11 months ago (2012-06-12 06:48:36 UTC) #7
Vino
11 years, 11 months ago (2012-06-12 06:50:56 UTC) #8
Okay, the retval is in now. I studied the code to figure out what the proper
line should be, and I'm pretty satisfied with this. I did a good bit of testing
and it doesn't seem to have any effect either way on any features I can find.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b