Issue 6258055: Foobar theme color palette moved to seperate file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6258055: Foobar theme color palette moved to seperate file.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by jaiditya

Modified:
11 years, 11 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Foobar theme color palette moved to seperate file.

Patch Set 2 : Foobar theme color palette moved to seperate file. #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	MoinMoin/themes/foobar/static/css/stylus/color_palette.styl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ThomasJWaldmann

http://codereview.appspot.com/6258055/diff/1/MoinMoin/themes/foobar/static/css/stylus/color_palette.styl File MoinMoin/themes/foobar/static/css/stylus/color_palette.styl (right): http://codereview.appspot.com/6258055/diff/1/MoinMoin/themes/foobar/static/css/stylus/color_palette.styl#newcode1 MoinMoin/themes/foobar/static/css/stylus/color_palette.styl:1: //color palette has been defined this comment reminds a ...

11 years, 11 months ago (2012-06-03 13:48:08 UTC) #1

jaiditya

11 years, 11 months ago (2012-06-03 14:53:30 UTC) #2

On 2012/06/03 13:48:08, ThomasJWaldmann wrote:
>
http://codereview.appspot.com/6258055/diff/1/MoinMoin/themes/foobar/static/cs...
> File MoinMoin/themes/foobar/static/css/stylus/color_palette.styl (right):
> 
>
http://codereview.appspot.com/6258055/diff/1/MoinMoin/themes/foobar/static/cs...
> MoinMoin/themes/foobar/static/css/stylus/color_palette.styl:1: //color palette
> has been defined
> this comment reminds a little of "all your base"'s "war has begun".
> 
> so if you did not intend it for the laughs, maybe choose a comment that makes
> more sense and has more semantic contents.

comment changed.

Expand All Messages | Collapse All Messages