Issue 6258046: Foobar theme color palette variables renamed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6258046: Foobar theme color palette variables renamed.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by jaiditya

Modified:
11 years, 12 months ago

Reviewers:
waldi, Reimar Bauer

Visibility:
Public.

More Reviews

Description

Foobar theme color palette variables renamed.

Patch Set 1 #

Total comments: 4

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	MoinMoin/themes/foobar/static/css/stylus/main.styl	View		7 chunks	+12 lines, -12 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

waldi

http://codereview.appspot.com/6258046/diff/1/MoinMoin/themes/foobar/static/css/stylus/main.styl File MoinMoin/themes/foobar/static/css/stylus/main.styl (right): http://codereview.appspot.com/6258046/diff/1/MoinMoin/themes/foobar/static/css/stylus/main.styl#newcode21 MoinMoin/themes/foobar/static/css/stylus/main.styl:21: font_color = #444444 you mean "text color"? http://codereview.appspot.com/6258046/diff/1/MoinMoin/themes/foobar/static/css/stylus/main.styl#newcode22 MoinMoin/themes/foobar/static/css/stylus/main.styl:22: ...

11 years, 12 months ago (2012-05-25 19:10:15 UTC) #2

jaiditya

11 years, 12 months ago (2012-05-25 19:27:43 UTC) #3

http://codereview.appspot.com/6258046/diff/1/MoinMoin/themes/foobar/static/cs...
File MoinMoin/themes/foobar/static/css/stylus/main.styl (right):

http://codereview.appspot.com/6258046/diff/1/MoinMoin/themes/foobar/static/cs...
MoinMoin/themes/foobar/static/css/stylus/main.styl:21: font_color = #444444
On 2012/05/25 19:10:15, waldi wrote:
> you mean "text color"?

yeah.

http://codereview.appspot.com/6258046/diff/1/MoinMoin/themes/foobar/static/cs...
MoinMoin/themes/foobar/static/css/stylus/main.styl:22: base_color = #eeeeee
On 2012/05/25 19:10:15, waldi wrote:
> "base" is no good name.
as body_bg_color creates a confusion as what "body" refers to. So I thought
using base would not cause any such confusion.

Expand All Messages | Collapse All Messages