routes like placenames support cont.

[uemit.seren, 2012-06-30 11:00:06]

http://codereview.appspot.com/6257054/diff/1/gwtp-core/gwtp-mvp-client/src/ma...
File
gwtp-core/gwtp-mvp-client/src/main/java/com/gwtplatform/mvp/client/proxy/ParameterizedPlaceRequest.java
(right):

http://codereview.appspot.com/6257054/diff/1/gwtp-core/gwtp-mvp-client/src/ma...
gwtp-core/gwtp-mvp-client/src/main/java/com/gwtplatform/mvp/client/proxy/ParameterizedPlaceRequest.java:179:
pathParams.put(parameterName, parts[i]);
Is this really correct? Because when I tested it, my path parameter value got
overwritten with the path parameter's name

[travaller88, 2012-08-28 18:18:39]

when will this be added into gwtp trunk?

[travaller88, 2012-09-23 12:33:16]

i tested out. the sample work ok but got null pointer on     String val =
params.get(key); //can be improve 
20:26:47.791 [ERROR] [gwtpsample] Uncaught exception escaped
java.lang.NullPointerException: null
    at
com.gwtplatform.mvp.client.proxy.ParameterizedPlaceRequest.getParameter(ParameterizedPlaceRequest.java:187)
    at
com.gwtplatform.samples.basic.client.UserPresenter.prepareFromRequest(UserPresenter.java:76)
    at
com.gwtplatform.mvp.client.proxy.ProxyPlaceAbstract$3$1.execute(ProxyPlaceAbstract.java:205)
    at
com.google.gwt.core.client.impl.SchedulerImpl$Task$.executeScheduled$(SchedulerImpl.java:50)
    at
com.google.gwt.core.client.impl.SchedulerImpl.runScheduledTasks(SchedulerImpl.java:228)
    at
com.google.gwt.core.client.impl.SchedulerImpl.flushPostEventPumpCommands(SchedulerImpl.java:388)
    at
com.google.gwt.core.client.impl.SchedulerImpl$Flusher.execute(SchedulerImpl.java:78)
    at
com.google.gwt.core.client.impl.SchedulerImpl.execute(SchedulerImpl.java:138)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
    at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
    at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)
    at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessagesWhileWaitingForReturn(BrowserChannelServer.java:337)
    at
com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:218)
    at
com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:136)
    at com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:561)
    at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeObject(ModuleSpace.java:269)
    at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeObject(JavaScriptHost.java:91)
    at com.google.gwt.core.client.impl.Impl.apply(Impl.java)
    at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:213)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
    at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
    at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)
    at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessages(BrowserChannelServer.java:292)
    at
com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:546)
    at
com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:363)
    at java.lang.Thread.run(Thread.java:680)

[travaller88, 2012-10-04 08:42:03]

Hi all,
    I did below changes to ParameterizedPlaceRequest in order to make it work. 
When can this checkin into trunk?





  @Override
  public String getParameter(String key, String defaultValue) {
//    String val = params.get(key);
//    if (val != null) {
//      return val;
//    }
//    val = pathParams.get(key);
//    if (val != null) {
//      return val;
//    }
//    return defaultValue;
	  

		String val = defaultValue;

		if (params != null)
			val = params.get(key);

		if (val != null) {
			return val;
		}

		if (pathParams != null)
			val = pathParams.get(key);

		if (val != null) {

			return val;
		}

		return defaultValue;
  }

  @Override
  public Set<String> getParameterNames() {
    
//	  return params.keySet();
	  
	  if(params !=null)
		  return params.keySet();
	  
	  return null;
    
  }