code review 6255068: lib9/dial: add support for IPv6

lib9/dial: add support for IPv6

The function p9dialparse() returns the host as a sockaddr_storage
structure instead of a u32int, to be able to handle both IPv4
and IPv6 addresses. Because the sockaddr_storage structure also
handle port numbers and Unix path names, there is no longer
need to set them in the calling functions. However, these values
are still returned for convenience.

The sockaddr_in and sockaddr_un structures have been replaced
by sockaddr_storage to handle Unix, IPv4 and IPv6 sockets.

Names and addresses are resolved using either gethostbyname()
or getaddrinfo() functions.

The getaddrinfo() function is documented in RFC2553 and standardized
since POSIX.1-2001. It supports both IPv4 and IPv6 addresses.
The gethostbyname() function is deprecated since POSIX.1-2008.
However, some libc implementations don't handle getaddrinfo()
properly, thus we preferred to try gethostbyname() first.

I've tried to preserve most of the old code logic to prevent
from surprising or unwanted behavior.

[0intro, 2012-05-31 12:50:06]

Hello rsc,

I'd like you to review this change to
https://code.google.com/p/plan9port/

[rsc, 2012-06-02 17:02:19]

LGTM

http://codereview.appspot.com/6255068/diff/5002/src/lib9/dial.c
File src/lib9/dial.c (right):

http://codereview.appspot.com/6255068/diff/5002/src/lib9/dial.c#newcode22
src/lib9/dial.c:22: int
static int?

[0intro, 2012-06-02 19:28:30]

https://codereview.appspot.com/6255068/diff/5002/src/lib9/dial.c
File src/lib9/dial.c (right):

https://codereview.appspot.com/6255068/diff/5002/src/lib9/dial.c#newcode22
src/lib9/dial.c:22: int
On 2012/06/02 17:02:19, rsc wrote:
> static int?

Done.

[rsc, 2012-06-02 19:40:47]

LGTM

[0intro, 2012-06-02 19:54:44]

*** Submitted as 697c23cebcec ***

lib9/dial: add support for IPv6

The function p9dialparse() returns the host as a sockaddr_storage
structure instead of a u32int, to be able to handle both IPv4
and IPv6 addresses. Because the sockaddr_storage structure also
handle port numbers and Unix path names, there is no longer
need to set them in the calling functions. However, these values
are still returned for convenience.

The sockaddr_in and sockaddr_un structures have been replaced
by sockaddr_storage to handle Unix, IPv4 and IPv6 sockets.

Names and addresses are resolved using either gethostbyname()
or getaddrinfo() functions.

The getaddrinfo() function is documented in RFC2553 and standardized
since POSIX.1-2001. It supports both IPv4 and IPv6 addresses.
The gethostbyname() function is deprecated since POSIX.1-2008.
However, some libc implementations don't handle getaddrinfo()
properly, thus we preferred to try gethostbyname() first.

I've tried to preserve most of the old code logic to prevent
from surprising or unwanted behavior.

R=rsc
http://codereview.appspot.com/6255068

[rsc, 2012-09-04 22:43:01]

This fails on OS X.

listen1 tcp!localhost!9001 date

gives EINVAL returned from announce. Any ideas?