Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(872)

Issue 6251048: [google] make the temp names in FDO/LIPO demanglable

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by xur
Modified:
12 years, 11 months ago
Reviewers:
davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/gcc/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M l-ipo.c View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
xur
Hi, This is for google branches only. It changes the format of the temp function ...
12 years, 11 months ago (2012-05-24 18:38:59 UTC) #1
davidxl
12 years, 11 months ago (2012-05-24 18:39:57 UTC) #2
Ok.

David

On Thu, May 24, 2012 at 11:38 AM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This is for google branches only.
>
> It changes the format of the temp function name so that they
> can be demangled.
>
> Tested with regression tests.
>
> Google ref b/5733865.
>
> Thanks,
>
> 2012-05-24   Rong Xu  <xur@google.com>
>
>        * l-ipo.c (create_unique_name): Make temp names demanglable.
>
> Index: l-ipo.c
> ===================================================================
> --- l-ipo.c     (revision 187817)
> +++ l-ipo.c     (working copy)
> @@ -1726,15 +1726,15 @@ create_unique_name (tree decl, unsigned module_id)
>       char *n;
>       unsigned fno =  FUNC_DECL_FUNC_ID (context);
>       n = (char *)alloca (strlen (name) + 15);
> -      sprintf (n, "%s_%u", name, fno);
> +      sprintf (n, "%s.%u", name, fno);
>       name = n;
>     }
>
>   assembler_name = (char*) alloca (strlen (name) + 30);
> -  sprintf (assembler_name, "%s_cmo_%u", name, module_id);
> +  sprintf (assembler_name, "%s.cmo.%u", name, module_id);
>   seq = get_name_seq_num (assembler_name);
>   if (seq)
> -    sprintf (assembler_name, "%s_%d", assembler_name, seq);
> +    sprintf (assembler_name, "%s.%d", assembler_name, seq);
>
>   assemb_id = get_identifier (assembler_name);
>
>
> --
> This patch is available for review at http://codereview.appspot.com/6251048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b