Issue 6249066: code review 6249066: runtime: do not unset the special bit after finalization.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6249066: code review 6249066: runtime: do not unset the special bit after finalization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by remyoudompheng

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc, remy_archlinux.org

Visibility:
Public.

Description

runtime: do not unset the special bit after finalization. A block with finalizer might also be profiled. The special bit is needed to unregister the block from the profile. It will be unset only when the block is freed. Fixes issue 3668.

Patch Set 1 #

Patch Set 2 : diff -r ac7250065a04 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ac7250065a04 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f5bb195f88cf https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/pkg/runtime/mfinal.c	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-05-29 20:27:21 UTC) #1

remyoudompheng

Ah, it should sort of fix issue 3668 but i think i have described the ...

12 years, 11 months ago (2012-05-29 21:40:36 UTC) #3

remyoudompheng

12 years, 11 months ago (2012-05-30 06:04:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=4a10c887bb3e ***

runtime: do not unset the special bit after finalization.

A block with finalizer might also be profiled. The special bit
is needed to unregister the block from the profile. It will be
unset only when the block is freed.

Fixes issue 3668.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6249066

Expand All Messages | Collapse All Messages