Issue 6247062: code review 6247062: misc/cgo/stdio: split stdout/stderr into a separate file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6247062: code review 6247062: misc/cgo/stdio: split stdout/stderr into a separate file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by jsing

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

misc/cgo/stdio: split stdout/stderr into a separate file Split stdout/stderr into a separate file so that can be handled differently on some platforms. Both NetBSD and OpenBSD have defines for stdout/stderr that require some coercion in order for cgo to handle them correctly.

Patch Set 1 : diff -r d34e1877830c https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r d34e1877830c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 02305cc6b5de https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	misc/cgo/stdio/file.go	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	A	misc/cgo/stdio/stdio.go	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-05-31 16:40:11 UTC) #1

jsing

12 years, 11 months ago (2012-06-04 15:39:05 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a98657dda373 ***

misc/cgo/stdio: split stdout/stderr into a separate file

Split stdout/stderr into a separate file so that can be handled
differently on some platforms. Both NetBSD and OpenBSD have defines
for stdout/stderr that require some coercion in order for cgo to
handle them correctly.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6247062

Expand All Messages | Collapse All Messages