code review 6245063: runtime: handle windows exceptions, even in cgo programs

runtime: handle windows exceptions, even in cgo programs

Fixes issue 3543.

[brainman, 2012-05-28 07:01:35]

Hello golang-dev@googlegroups.com (cc: hectorchu@gmail.com, vcc.163@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[kardia, 2012-05-28 17:05:32]

Works for me on Win7 amd64.
Thanks you Alex.


On 2012/05/28 07:01:35, brainman wrote:
> Hello mailto:golang-dev@googlegroups.com (cc: mailto:hectorchu@gmail.com,
mailto:vcc.163@gmail.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

[rsc, 2012-05-29 18:13:08]

LGTM

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/crash_test.go
File src/pkg/runtime/crash_test.go (right):

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/crash_test.go#ne...
src/pkg/runtime/crash_test.go:24: const source = `
Please move this to be a global variable at the bottom of the file, maybe named
crashSource. It's hard to see the test function code with this other code nested
in the middle.

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/proc.c#newcode761
src/pkg/runtime/proc.c:761: SEH seh;	// It is used by windows-386 only.
Unfortunately, seh needs
Please move multiline comment above the variable declaration, instead of
indenting on multiple lines.

[brainman, 2012-05-30 05:11:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=85e2b70e9d44 ***

runtime: handle windows exceptions, even in cgo programs

Fixes issue 3543.

R=golang-dev, kardianos, rsc
CC=golang-dev, hectorchu, vcc.163
http://codereview.appspot.com/6245063

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/crash_test.go
File src/pkg/runtime/crash_test.go (right):

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/crash_test.go#ne...
src/pkg/runtime/crash_test.go:24: const source = `
On 2012/05/29 18:13:08, rsc wrote:
> Please move this to be a global variable at the bottom of the file, maybe
named
> crashSource. It's hard to see the test function code with this other code
nested
> in the middle.

Done.

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

http://codereview.appspot.com/6245063/diff/3/src/pkg/runtime/proc.c#newcode761
src/pkg/runtime/proc.c:761: SEH seh;	// It is used by windows-386 only.
Unfortunately, seh needs
On 2012/05/29 18:13:08, rsc wrote:
> Please move multiline comment above the variable declaration, instead of
> indenting on multiple lines.

Done.