Issue 6244065: Throwing IOException from CredentialStore methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6244065: Throwing IOException from CredentialStore methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rmistry

Modified:
11 years, 11 months ago

Reviewers:
yanivi

Base URL:
https://google-oauth-java-client.googlecode.com/hg/

Visibility:
Public.

Description

Fix for http://code.google.com/p/google-oauth-java-client/issues/detail?id=40 : CredentialStore methods should declare throws IOException.

Patch Set 2 : Addressing code review comments #

Patch Set 3 : Minor fix #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -20 lines)			Patch
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java	View	1	3 chunks	+14 lines, -2 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialRefreshListener.java	View	1	5 chunks	+24 lines, -11 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java	View	1	3 chunks	+20 lines, -3 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStoreRefreshListener.java	View	1 2	3 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

yanivi

LGTM Thanks for taking care of this Ravi! http://codereview.appspot.com/6244065/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java File google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java (right): http://codereview.appspot.com/6244065/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java#newcode48 google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java:48: boolean ...

11 years, 11 months ago (2012-05-30 19:58:29 UTC) #2

rmistry

http://codereview.appspot.com/6244065/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java File google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java (right): http://codereview.appspot.com/6244065/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java#newcode48 google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java:48: boolean load(String userId, Credential credential) throws IOException; On 2012/05/30 ...

11 years, 11 months ago (2012-05-31 11:30:48 UTC) #3

Submitting..

Expand All Messages | Collapse All Messages