Issue 6243069: code review 6243069: go-uuid: Make uuid_test.go independent of the system clock.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6243069: code review 6243069: go-uuid: Make uuid_test.go independent of the system clock. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by dsymonds

Modified:
12 years, 5 months ago

Reviewers:

CC:
borman

Visibility:
Public.

Description

go-uuid: Make uuid_test.go independent of the system clock. The test depends on an advancing clock, but it can sometimes run fast enough that the clock has not advanced.

Patch Set 1 #

Patch Set 2 : diff -r 4f1c1d3e2957 https://code.google.com/p/go-uuid #

Patch Set 3 : diff -r 4f1c1d3e2957 https://code.google.com/p/go-uuid #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	uuid/time.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
	M	uuid/uuid_test.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello borman@google.com (cc: borman@google.com), I'd like you to review this change to https://code.google.com/p/go-uuid

12 years, 6 months ago (2012-05-30 00:42:04 UTC) #1

borman

12 years, 5 months ago (2012-06-05 14:46:07 UTC) #5

*** Submitted as http://code.google.com/p/go-uuid/source/detail?r=5fac954758f5
***

go-uuid: Make uuid_test.go independent of the system clock.

The test depends on an advancing clock, but it can sometimes run
fast enough that the clock has not advanced.

R=borman
CC=borman
http://codereview.appspot.com/6243069

Committer: Paul Borman <borman@google.com>

Expand All Messages | Collapse All Messages