Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 6221068: Move viewport on arrow key (issue382). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by Andi
Modified:
13 years, 10 months ago
Reviewers:
techtonik, GvR
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Move viewport on arrow key (issue382).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M static/script.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7
Andi Albrecht
14 years ago (2012-05-23 19:15:41 UTC) #1
techtonik
Any place to play with?
14 years ago (2012-05-23 21:31:25 UTC) #2
techtonik
I am a bad reviewer, because I dislike this "feature" too. For PgUp/PgDown should me ...
14 years ago (2012-05-23 21:32:41 UTC) #3
techtonik
s/me/move/
14 years ago (2012-05-23 21:32:56 UTC) #4
GvR
LGTM
14 years ago (2012-05-24 15:48:14 UTC) #5
Andi Albrecht
This is now live. Thanks for the review!
14 years ago (2012-05-24 18:30:12 UTC) #6
techtonik
14 years ago (2012-05-24 19:44:08 UTC) #7
Cool stuff. I'd eliminate delay between keypresses for it if I had some free
time.

http://www.duchnik.com/tutorials/2011/08/30/beginner-html5-game-development-p...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b