Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 6221063: Allow upload.py to upload binary files that are not images. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Roger Tawa
Modified:
11 years, 10 months ago
Reviewers:
techtonik, gvrpython, M-A
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

Allow upload.py to upload binary files that are not images. Committed: http://code.google.com/p/rietveld/source/detail?r=d7e0520c9f89d236e40268f93ef01b9048a5eb9e&name=default

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M upload.py View 5 chunks +18 lines, -23 lines 0 comments Download

Messages

Total messages: 5
Roger Tawa
11 years, 10 months ago (2012-05-22 20:26:11 UTC) #1
M-A
lgtm, cc'ing the ML in case there's any opinion. We need the binary files to ...
11 years, 10 months ago (2012-05-22 20:28:12 UTC) #2
techtonik
How do you plan to fight with spamming tracker with random binary stuff to death? ...
11 years, 10 months ago (2012-05-23 17:50:41 UTC) #3
gvrpython
Let's cross that bridge when we get to it. Note that since this is a ...
11 years, 10 months ago (2012-05-23 17:52:53 UTC) #4
techtonik
11 years, 10 months ago (2012-05-23 18:11:58 UTC) #5
On Wed, May 23, 2012 at 8:52 PM, Guido van Rossum <guido@python.org> wrote:
> Let's cross that bridge when we get to it. Note that since this is a
> pure client-side change, the actual ability to upload binaries hasn't
> changed. Also note that files are limited to 1MB, not very attractive
> for spammers.

All right. 1MB is a real showstopper.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b