Allow upload.py to upload binary files that are not images.

Allow upload.py to upload binary files that are not images.

Committed: http://code.google.com/p/rietveld/source/detail?r=d7e0520c9f89d236e40268f93ef01b9048a5eb9e&name=default

[M-A, 2012-05-22 20:28:12]

lgtm, cc'ing the ML in case there's any opinion.

We need the binary files to be uploaded so they can be downloaded by the commit
queue.

[techtonik, 2012-05-23 17:50:41]

How do you plan to fight with spamming tracker with random binary stuff to
death? I can immediately see it as a free hosting.

[gvrpython, 2012-05-23 17:52:53]

Let's cross that bridge when we get to it. Note that since this is a
pure client-side change, the actual ability to upload binaries hasn't
changed. Also note that files are limited to 1MB, not very attractive
for spammers.

On Wed, May 23, 2012 at 10:50 AM,  <techtonik@gmail.com> wrote:
> How do you plan to fight with spamming tracker with random binary stuff
> to death? I can immediately see it as a free hosting.
>
>
> http://codereview.appspot.com/6221063/
>
> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to codereview-discuss@googlegroups.com.
> To unsubscribe from this group, send email to
> codereview-discuss+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.
>



-- 
--Guido van Rossum (python.org/~guido)

[techtonik, 2012-05-23 18:11:58]

On Wed, May 23, 2012 at 8:52 PM, Guido van Rossum <guido@python.org> wrote:
> Let's cross that bridge when we get to it. Note that since this is a
> pure client-side change, the actual ability to upload binaries hasn't
> changed. Also note that files are limited to 1MB, not very attractive
> for spammers.

All right. 1MB is a real showstopper.