Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5191)

Issue 6221046: Allow tweaks in Lyrics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by dak
Modified:
11 years, 10 months ago
Reviewers:
Keith, janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Allow tweaks in Lyrics. Since lyrics are no longer wrapped in EventChord, there is no point in keeping tweaks from working inside of Lyrics contexts.

Patch Set 1 #

Patch Set 2 : Add regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A input/regression/lyric-tweak.ly View 1 1 chunk +18 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Keith
I'm having difficulty demonstrating that this works. \layout { \context { \Lyrics \consists "Tweak_engraver" }} ...
11 years, 11 months ago (2012-05-21 06:25:13 UTC) #1
dak
On 2012/05/21 06:25:13, Keith wrote: > I'm having difficulty demonstrating that this works. > > ...
11 years, 11 months ago (2012-05-21 07:49:47 UTC) #2
Keith
On Mon, 21 May 2012 00:49:48 -0700, <dak@gnu.org> wrote: > #red [...] instead of #'red ...
11 years, 11 months ago (2012-05-21 08:00:45 UTC) #3
janek
Cool! So for example http://lsr.dsi.unimi.it/LSR/Item?id=643 will work without having to do something in \layout block. ...
11 years, 11 months ago (2012-05-21 14:47:41 UTC) #4
dak
11 years, 11 months ago (2012-05-21 15:34:14 UTC) #5
On 2012/05/21 14:47:41, janek wrote:
> Cool!  So for example http://lsr.dsi.unimi.it/LSR/Item?id=643 will work
without
> having to do something in \layout block.

Well, it is not exactly like the rest of the snippet is easy-peasy.

> I love changes like this!

I have the strong suspicion that the genesis of this snippet included half an
hour of head-scratching and code-rewriting because the tweak would just refuse
to work.

It is not really a spectacular change.  Just one surprise less.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b