Issue 6220061: Tunnel name requests through factory, forcing custom effect and custom prog stage to use same impl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6220061: Tunnel name requests through factory, forcing custom effect and custom prog stage to use same impl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by bsalomon

Modified:
13 years, 10 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : cleanup #

Total comments: 5

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -26 lines)			Patch
M	include/gpu/GrCustomStage.h	View	1	3 chunks	+8 lines, -5 lines	4 comments	Download
M	include/gpu/GrProgramStageFactory.h	View	1	3 chunks	+11 lines, -2 lines	1 comment	Download
M	src/gpu/effects/GrConvolutionEffect.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View		3 chunks	+7 lines, -13 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramStage.h	View	1	3 chunks	+11 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramStage.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

With this change a GrCustomStage implementer needs to define "static const char* Name()" in a ...

13 years, 10 months ago (2012-05-21 20:01:06 UTC) #1

TomH

LGTM, mostly http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h File include/gpu/GrCustomStage.h (right): http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h#newcode19 include/gpu/GrCustomStage.h:19: Subclasses must have a function produces a ...

13 years, 10 months ago (2012-05-21 20:42:05 UTC) #2

bsalomon

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h File include/gpu/GrCustomStage.h (right): http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h#newcode19 include/gpu/GrCustomStage.h:19: Subclasses must have a function produces a human-readable name: ...

13 years, 10 months ago (2012-05-21 20:55:35 UTC) #3

Closed with r4019

Expand All Messages | Collapse All Messages