Tunnel name requests through factory, forcing custom effect and custom prog stage to use same impl

[bsalomon, 2012-05-21 20:01:06]

With this change a GrCustomStage implementer needs to define "static const char*
Name()" in a GrCustomStage subclass rather than having to implement separate
name() functions in the generic and GL-specific subclasses.

[TomH, 2012-05-21 20:42:05]

LGTM, mostly

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h
File include/gpu/GrCustomStage.h (right):

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h#n...
include/gpu/GrCustomStage.h:19: Subclasses must have a function produces a
human-readable name:
typo: omitted "that"

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h#n...
include/gpu/GrCustomStage.h:64: const char* name() const { return
this->getFactory().name(); }
Ugh - inefficient round-trip redirection, although it allows us to not have to
redefine name() in every subclass.

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrProgramStageFac...
File include/gpu/GrProgramStageFactory.h (right):

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrProgramStageFac...
include/gpu/GrProgramStageFactory.h:101: /** This class is a singleton. This
function returns the single instance.
Thanks for adding.

[bsalomon, 2012-05-21 20:55:35]

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h
File include/gpu/GrCustomStage.h (right):

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h#n...
include/gpu/GrCustomStage.h:19: Subclasses must have a function produces a
human-readable name:
On 2012/05/21 20:42:05, TomH wrote:
> typo: omitted "that"

Done.

http://codereview.appspot.com/6220061/diff/2001/include/gpu/GrCustomStage.h#n...
include/gpu/GrCustomStage.h:64: const char* name() const { return
this->getFactory().name(); }
On 2012/05/21 20:42:05, TomH wrote:
> Ugh - inefficient round-trip redirection, although it allows us to not have to
> redefine name() in every subclass.

Right. I think this is a low frequency operation in code that isn't performance
critical.

[bsalomon, 2012-05-21 20:58:22]

Closed with r4019