code review 6212055: misc/chrome/gophertool: lower CL number's lower bound a...

misc/chrome/gophertool: lower CL number's lower bound and fix input focus on Mac
As our CL number could be as small as 152046, changed CL number's lower bound
to 150000. Hopefully our issue count won't reach 150000 any time soon.
Chrome on Mac OS X has very strange behavior regarding the focus, although we
force the focus to the input box on load, the page still come up with focus on
"issue". Set the tabindex of the input box as a workaround.

[minux1, 2012-05-16 20:10:58]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-05-16 20:14:13]

LGTM

On Wed, May 16, 2012 at 1:10 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> misc/chrome/gophertool: lower CL number's lower bound and fix input
> focus on Mac
> As our CL number could be as small as 152046, changed CL number's lower
> bound
> to 150000. Hopefully our issue count won't reach 150000 any time soon.
> Chrome on Mac OS X has very strange behavior regarding the focus,
> although we
> force the focus to the input box on load, the page still come up with
> focus on
> "issue". Set the tabindex of the input box as a workaround.
>
> Please review this at
http://codereview.appspot.com/**6212055/<http://codereview.appspot.com/6212055/>
>
> Affected files:
>  M misc/chrome/gophertool/gopher.**js
>  M misc/chrome/gophertool/popup.**html
>
>
> Index: misc/chrome/gophertool/gopher.**js
> ==============================**==============================**=======
> --- a/misc/chrome/gophertool/**gopher.js
> +++ b/misc/chrome/gophertool/**gopher.js
> @@ -12,7 +12,7 @@
>     }
>
>     if (numericRE.test(t)) {
> -        if (t < 1000000) {
> +        if (t < 150000) {
>             return
"http://code.google.com/p/go/**issues/detail?id=<http://code.google.com/p/go/issues/detail?id=>"
> + t;
>         }
>         return
"http://codereview.appspot.**com/<http://codereview.appspot.com/>"
> + t + "/";
> Index: misc/chrome/gophertool/popup.**html
> ==============================**==============================**=======
> --- a/misc/chrome/gophertool/**popup.html
> +++ b/misc/chrome/gophertool/**popup.html
> @@ -48,7 +48,7 @@
>  <a href="#"
onclick="openURL('http://**codereview.appspot.com/'<http://codereview.appspot.com/'>
> )">**codereview</a>,
>  <a href="#"
onclick="openURL('http://code.**google.com/p/go/source/list'<http://code.google.com/p/go/source/list'>
> )"**>commit</a>, or
>  <a href="#"
onclick="openURL('http://**golang.org/pkg/'<http://golang.org/pkg/'>)">pkg</a>
> id/name:</small>
> -<form style='margin: 0' onsubmit="return navigate();"><nobr><input
> id="inputbox" size=10 /><input type="submit" value="go" /></nobr></form>
> +<form style='margin: 0' onsubmit="return navigate();"><nobr><input
> id="inputbox" size=10 tabindex=1 /><input type="submit" value="go"
> /></nobr></form>
>  <small>Also: <a href="#"
onclick="openURL('http://**build.golang.org/'<http://build.golang.org/'>
> )">**buildbots</small>
>  </body>
>  </html>
>
>
>

[minux1, 2012-05-16 20:22:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=aec1f7073ea8 ***

misc/chrome/gophertool: lower CL number's lower bound and fix input focus on Mac
As our CL number could be as small as 152046, changed CL number's lower bound
to 150000. Hopefully our issue count won't reach 150000 any time soon.
Chrome on Mac OS X has very strange behavior regarding the focus, although we
force the focus to the input box on load, the page still come up with focus on
"issue". Set the tabindex of the input box as a workaround.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6212055