code review 6211079: math/big: implement JSON un/marshaling support for Ints

math/big: implement JSON un/marshaling support for Ints

Also: simplified some existing tests.

No support for Rats for now because the precision-preserving
default notation (fractions of the form a/b) is not a valid
JSON value.

Fixes issue 3657.

[gri, 2012-05-22 22:33:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-05-22 22:37:34]

LGTM

http://codereview.appspot.com/6211079/diff/8001/src/pkg/math/big/int_test.go
File src/pkg/math/big/int_test.go (right):

http://codereview.appspot.com/6211079/diff/8001/src/pkg/math/big/int_test.go#...
src/pkg/math/big/int_test.go:1412: for j := 0; j < 2; j++ {
Minor and your preference, but I like to write this as:

for _, negative := range []bool{false, true} {

}

Maybe a little longer, but "negative" (or "neg") reads better than "j".

[gri, 2012-05-22 22:58:19]

PTAL.

Waiting for rsc, in case he has some JSON-related thoughts.
- gri

On Tue, May 22, 2012 at 3:37 PM,  <bradfitz@golang.org> wrote:
> LGTM
>
>
>
> http://codereview.appspot.com/6211079/diff/8001/src/pkg/math/big/int_test.go
> File src/pkg/math/big/int_test.go (right):
>
>
http://codereview.appspot.com/6211079/diff/8001/src/pkg/math/big/int_test.go#...
> src/pkg/math/big/int_test.go:1412: for j := 0; j < 2; j++ {
> Minor and your preference, but I like to write this as:
>
> for _, negative := range []bool{false, true} {
>
> }
>
> Maybe a little longer, but "negative" (or "neg") reads better than "j".
>
> http://codereview.appspot.com/6211079/

[rsc, 2012-05-23 00:18:50]

LGTM

Nice.

[gri, 2012-05-23 00:20:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=10f594c76fa0 ***

math/big: implement JSON un/marshaling support for Ints

Also: simplified some existing tests.

No support for Rats for now because the precision-preserving
default notation (fractions of the form a/b) is not a valid
JSON value.

Fixes issue 3657.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/6211079