Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8478)

Issue 6211049: Adding .classpath and putting jars under libs and *-sources.jars under libs-sources. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rmistry
Modified:
11 years, 11 months ago
Reviewers:
yanivi
Base URL:
https://google-oauth-java-client.googlecode.com/hg/
Visibility:
Public.

Description

Fix for http://code.google.com/p/google-oauth-java-client/issues/detail?id=38 : New structure for jars in zip package.

Patch Set 1 #

Patch Set 2 : Minor fix #

Patch Set 3 : Addressing code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
A google-oauth-client-assembly/.classpath View 1 chunk +18 lines, -0 lines 0 comments Download
M google-oauth-client-assembly/assembly.xml View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M google-oauth-client-assembly/pom.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M google-oauth-client-assembly/readme.html View 1 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 5
rmistry
11 years, 11 months ago (2012-05-14 15:34:48 UTC) #1
yanivi
LGTM
11 years, 11 months ago (2012-05-14 15:57:10 UTC) #2
yanivi
On 2012/05/14 15:57:10, yanivi wrote: > LGTM Actually, I see one problem: I see a ...
11 years, 11 months ago (2012-05-14 16:00:01 UTC) #3
rmistry
On 2012/05/14 16:00:01, yanivi wrote: > On 2012/05/14 15:57:10, yanivi wrote: > > LGTM > ...
11 years, 11 months ago (2012-05-14 16:15:24 UTC) #4
yanivi
11 years, 11 months ago (2012-05-14 17:21:09 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b